[go_router_builder] Cleans up builder code. #4356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunhtai
force-pushed
the
cleanup_builder
branch
2 times, most recently
from
6a52cbf to
7b14077
Compare
11 tasks
chunhtai
commented
Jul 7, 2023
Collaborator
There was a problem hiding this comment.
Are you using this to validate that formatting doesn't change? If so, is there a reason you aren't just calling dart format?
Also, are you sure that any change in format output is a breaking change in dart_style? Because if it's not, you would want to pin this if you go this route.
Contributor
Author
There was a problem hiding this comment.
The test take the dart code as Library object and send it through code generator which produced a plan String output.
I then use dart_style to format the output string so that I can compare with the string from the golden file without worrying weird indents.
I could store the pre format out put to a dart file and run the dart format but I feel it add some extra step as well as extra cache files.
I still prefer to keep it as is, I will pin the version
Collaborator
There was a problem hiding this comment.
Please also move this allowance to the pinned dependencies section then, since it's likely that anyone using it should be pinning to avoid OOB errors.
Contributor
Author
There was a problem hiding this comment.
done also updated the comment on top, seemed like a typo
chunhtai
force-pushed
the
cleanup_builder
branch
from
a89ee29 to
49bb2e1
Compare
chunhtai
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 12, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 12, 2023
flutter/packages@188a846...2508714 2023-07-12 [email protected] ADD appBarBreakpoint (flutter/packages#4434) 2023-07-12 [email protected] Roll Flutter from 65ff3cb to 3ec96a8 (5 revisions) (flutter/packages#4415) 2023-07-12 [email protected] [image_picker] Roll dependancies to avoid error (flutter/packages#4431) 2023-07-12 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump com.android.billingclient:billing from 6.0.0 to 6.0.1 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#4422) 2023-07-12 [email protected] [file_selector] Avoids using path_provider in web example app. (flutter/packages#4445) 2023-07-12 [email protected] [rfw] Add some more documentation for RFW (flutter/packages#4349) 2023-07-12 [email protected] [ci] Enable LUCI legacy analysis (flutter/packages#4435) 2023-07-11 [email protected] [webview_flutter_wkwebview] NSError.toString (flutter/packages#4441) 2023-07-11 [email protected] [ci] Remove unused Chromium setup (flutter/packages#4437) 2023-07-11 [email protected] [flutter_plugin_tools] Reimplements the excerpt system inline in the tool, rather than relying on a separate package. (flutter/packages#4417) 2023-07-11 [email protected] [ci] Remove webview_flutter implementation opt outs for custom analysis (flutter/packages#4438) 2023-07-11 [email protected] [palette_generator] Add web support to unit tests (flutter/packages#4440) 2023-07-11 [email protected] [tool] Conditionalize color on `stdout` (flutter/packages#4436) 2023-07-11 [email protected] [go_router_builder] Cleans up builder code. (flutter/packages#4356) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 13, 2023
flutter/packages@188a846...2508714 2023-07-12 [email protected] ADD appBarBreakpoint (flutter/packages#4434) 2023-07-12 [email protected] Roll Flutter from 65ff3cb to 3ec96a8 (5 revisions) (flutter/packages#4415) 2023-07-12 [email protected] [image_picker] Roll dependancies to avoid error (flutter/packages#4431) 2023-07-12 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump com.android.billingclient:billing from 6.0.0 to 6.0.1 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#4422) 2023-07-12 [email protected] [file_selector] Avoids using path_provider in web example app. (flutter/packages#4445) 2023-07-12 [email protected] [rfw] Add some more documentation for RFW (flutter/packages#4349) 2023-07-12 [email protected] [ci] Enable LUCI legacy analysis (flutter/packages#4435) 2023-07-11 [email protected] [webview_flutter_wkwebview] NSError.toString (flutter/packages#4441) 2023-07-11 [email protected] [ci] Remove unused Chromium setup (flutter/packages#4437) 2023-07-11 [email protected] [flutter_plugin_tools] Reimplements the excerpt system inline in the tool, rather than relying on a separate package. (flutter/packages#4417) 2023-07-11 [email protected] [ci] Remove webview_flutter implementation opt outs for custom analysis (flutter/packages#4438) 2023-07-11 [email protected] [palette_generator] Add web support to unit tests (flutter/packages#4440) 2023-07-11 [email protected] [tool] Conditionalize color on `stdout` (flutter/packages#4436) 2023-07-11 [email protected] [go_router_builder] Cleans up builder code. (flutter/packages#4356) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional change, this is a refactoring of the builder code and pull out external library dependency
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.