[various] Remove unused flutter_driver dependencies #4347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
requested review from
LouiseHsu,
bparrishMines,
camsim99,
cbracken,
cyanglaz,
ditman,
gmackall,
hellohuanlin,
reidbaker,
tarrinneal and
vashworth
as code owners
github-actions
bot
added
p: camera
p: file_selector
p: google_maps_flutter
p: google_sign_in
p: image_picker
p: in_app_purchase
p: local_auth
p: path_provider
p: pointer_interceptor
p: quick_actions
p: shared_preferences
p: url_launcher
p: video_player
p: webview_flutter
platform-android
labels
hellohuanlin
approved these changes
Jun 29, 2023
stuartmorgan-g
added
override: no versioning needed
Collaborator
Author
|
Overrides: these are dev dependencies, so don't need to be versioned or mentioned in the changelog. |
ditman
approved these changes
Jun 29, 2023
Member
ditman
left a comment
ditman
left a comment
There was a problem hiding this comment.
Yikes, big offender on this one. Thanks for the cleanup! LGTM!
Collaborator
Author
I think I'm the offender; IIRC I did a bunch of the switch of the driver files to |
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 30, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 30, 2023
flutter/packages@d4752c4...53ed5a0 2023-06-30 [email protected] [google_maps_flutter_web] Add padding to newLatLngBounds implementation (flutter/packages#3452) 2023-06-29 [email protected] [various] Remove unused flutter_driver dependencies (flutter/packages#4347) 2023-06-29 [email protected] [ci] Add LUCI version of dart unit tests (flutter/packages#4265) 2023-06-29 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.8.21 to 1.8.22 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#4189) 2023-06-29 [email protected] [shared_preferences] Adds new clearWithParameters and getAllWithParameters methods to all platforms. (flutter/packages#4262) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flutter_driverhas been mostly replaced byintegration_test, but we still have a lot of remaining dependencies on the package. This removes the dependency from pubspec.yaml for all plugins that aren't actuallyimporting it.It also removes an old video_player test that has been disabled for years that was never updated from flutter_driver to integration_test; we've since added a lot more testing to video_player, so in practice this is cruft that we can just remove.
Closes flutter/flutter#85224
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).