Skip to content

[url_launcher] Remove nested third_party safari checker #4330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 11 commits into from
Jul 6, 2023
Merged

[url_launcher] Remove nested third_party safari checker #4330

auto-submit merged 11 commits into from
Jul 6, 2023

Conversation

@victorsanni
Copy link
Contributor

@victorsanni victorsanni commented Jun 27, 2023 •
edited by ditman
Loading

Remove nested third_party safari checker

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [x ] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@victorsanni victorsanni requested a review from ditman as a code owner June 27, 2023 20:01
@flutter-dashboard
Copy link

flutter-dashboard bot commented Jun 27, 2023

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

ditman
ditman requested changes Jun 28, 2023
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @victorsanni!

It needs a few fixes to land. Please check the failed "Checks" section for more info (I copied the most relevant bits under some of my comments). All checks need to pass before we can merge this!

Thanks!

@victorsanni victorsanni requested a review from ditman June 29, 2023 15:14
@ditman
Copy link
Member

ditman commented Jun 29, 2023 •
edited
Loading

The feature is tested, tests exist here:

@ditman ditman added autosubmit Merge PR when tree becomes green via auto submit App and removed needs tests labels Jun 29, 2023
@ditman
Copy link
Member

ditman commented Jun 29, 2023 •
edited
Loading

Thanks @victorsanni! This'll auto-land soon!

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 29, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 29, 2023

auto label is removed for flutter/packages, pr: 4330, due to This PR has not met approval requirements for merging. You are not a member of flutter-hackers and need 1 more review(s) in order to merge this PR.

  • Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

stuartmorgan-g
stuartmorgan-g approved these changes Jun 29, 2023
View reviewed changes
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit.

Do were already have tests covering Safari detection?

@ditman
Copy link
Member

ditman commented Jun 30, 2023

Do we already have tests covering Safari detection?

The tests verify that stuff works as expected when a navigator identifies itself as Safari (and when it doesn't). We don't have tests running on Safari though, the difference is tested by mocking the navigator values.

@victorsanni
Update url_launcher_web.dart
35de858 
Removed redundant check for 'Apple Computer, Inc.' vendor
@victorsanni
Merge branch 'main' into safari_check
713504c
ditman
ditman reviewed Jul 6, 2023
View reviewed changes
@ditman
Copy link
Member

ditman commented Jul 6, 2023

I think this is ready to go! Thanks @victorsanni for the clean-up!

@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 6, 2023
@auto-submit auto-submit bot merged commit 443e041 into flutter:main Jul 6, 2023
@victorsanni victorsanni deleted the safari_check branch July 6, 2023 23:39
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 7, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 7, 2023
@engine-flutter-autoroll
443e041 [url_launcher] Remove nested third_party safari checker (flut…
79ef9d1 
…ter/packages#4330)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 7, 2023
@engine-flutter-autoroll
Roll Packages from 771ec9b to 9bcf4bf (12 revisions) (#130143)
d5b8db3 
flutter/packages@771ec9b...9bcf4bf

2023-07-07 [email protected] [ci] Add LUCI web platform tests (flutter/packages#4391)
2023-07-07 [email protected] [webview_flutter] Enable unawaited_futures lint (flutter/packages#4271)
2023-07-07 [email protected] [ci] Add partial LUCI version of repo_checks (flutter/packages#4389)
2023-07-06 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.1.3 to 2.2.0 (flutter/packages#4302)
2023-07-06 [email protected] [webview_flutter_android][webview_flutter_wkwebview] Fixes unawaited_futures violations (flutter/packages#4354)
2023-07-06 [email protected] [local_auth] Update Windows Pigeon version (flutter/packages#4388)
2023-07-06 [email protected] [url_launcher] Remove nested third_party safari checker (flutter/packages#4330)
2023-07-06 [email protected] [ci] Add partial LUCI Android platform tests (flutter/packages#4381)
2023-07-06 [email protected] [ci] Switch `master` Linux custom package tests to LUCI (flutter/packages#4386)
2023-07-06 [email protected] [go_router] Exposes package-level privates (flutter/packages#4380)
2023-07-06 [email protected] [file_selector] Update to 1.0 (flutter/packages#4362)
2023-07-06 [email protected] Roll Flutter from 35085c3 to bc49cd1 (14 revisions) (flutter/packages#4387)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
Merged
Closed
Merged
@reidbaker reidbaker mentioned this pull request Jul 26, 2023
Merged
11 tasks
@reidbaker reidbaker mentioned this pull request Aug 4, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@ditman ditman ditman approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: url_launcher platform-web

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[url_launcher_web] Remove third_party code from package.

3 participants

@victorsanni @ditman @stuartmorgan-g