Skip to content

Update Xcode to 14.3.1 #4235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Jun 27, 2023
Merged

Update Xcode to 14.3.1 #4235

auto-submit merged 3 commits into from
Jun 27, 2023

Conversation

@vashworth
Copy link
Contributor

@vashworth vashworth commented Jun 16, 2023

Packages part of flutter/flutter#129019

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@vashworth vashworth mentioned this pull request Jun 16, 2023
Closed
5 tasks
@vashworth vashworth requested a review from keyonghan June 16, 2023 21:18
keyonghan
keyonghan approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vashworth
Copy link
Contributor Author

vashworth commented Jun 20, 2023

https://ci.chromium.org/ui/p/flutter/builders/try/Mac_arm64%20ios_platform_tests_shard_5%20master/4259/overview

Test packages/webview_flutter/webview_flutter_wkwebview is failing with:

flutter: ══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
flutter: The following PlatformException was thrown running a test (but after the test had completed):
flutter: PlatformException(NSInternalInconsistencyException, InstanceManager does not contain an NSURL with
flutter: identifier: 65554, null, null)
flutter:
flutter: When the exception was thrown, this was the stack:
flutter: #0      NSUrlHostApi.getAbsoluteString (package:webview_flutter_wkwebview/src/common/web_kit.g.dart:2823:7)
flutter: <asynchronous suspension>
flutter: #1      WebKitWebViewController._webView.<anonymous closure>.<anonymous closure> (package:webview_flutter_wkwebview/src/webkit_webview_controller.dart:255:48)
flutter: <asynchronous suspension>

@bparrishMines @cyanglaz Any ideas on what's going on?

Looks like similar issue to: flutter/flutter#128422

@cyanglaz
Copy link
Contributor

cyanglaz commented Jun 20, 2023 •
edited
Loading

I can reproduce it locally but inconsistent. I think it is a race condition where the object in the weakInstance is removed before it is accessed. I can't figure out where it was removed. It also doesn't seem to be related to the withWeakReferenceTo allows encapsulating class to be garbage collected test as shown in the log but more like an issue with can receive updates to history state'. (I tried to commented out can receive updates to history state and couldn't reproduce the failure, it could also be because its inconsistency so I'm not entirely sure. )

@bparrishMines is more familiar with the code than I am so it would be nice if @bparrishMines could take a look.

I also don't think it is related to the xcode migration as I can reproduce the same failure with XCode 14.2.
I'm going to trigger a re-run to see if it passes.

@cyanglaz cyanglaz mentioned this pull request Jun 20, 2023
Closed
2 tasks
@vashworth
Copy link
Contributor Author

vashworth commented Jun 26, 2023

submit-queue has been failing for a long time. I'm going to try updating the branch to unstick it.

@vashworth vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 27, 2023
@auto-submit auto-submit bot merged commit 2b307ac into flutter:main Jun 27, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 28, 2023
@engine-flutter-autoroll
2b307ac Update Xcode to 14.3.1 (flutter/packages#4235)
7d7c21d
This was referenced Jul 7, 2023
Merged
Closed
Merged
@reidbaker reidbaker mentioned this pull request Jul 26, 2023
Merged
11 tasks
@reidbaker reidbaker mentioned this pull request Aug 4, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@keyonghan keyonghan keyonghan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vashworth @cyanglaz @keyonghan