[go_router] Fixes a bug in debugLogDiagnostics to support StatefulShellRoute
#4177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashirshoaeb
changed the title
debugLogDiagnostics to support StatefulShellRoutedebugLogDiagnostics to support StatefulShellRoute
|
I'm the reporter and I just tested this, worked as expected! 🎉 |
chunhtai
reviewed
Jun 12, 2023
| sb.writeln(' => ${''.padLeft(depth * 2)}$fullPath'); | ||
| _debugFullPathsFor(route.routes, fullPath, depth + 1, sb); | ||
| } else if (route is ShellRoute) { | ||
| } else if (route is ShellRoute || route is StatefulShellRoute) { |
Contributor
There was a problem hiding this comment.
Suggested change
| } else if (route is ShellRoute || route is StatefulShellRoute) { | |
| } else if (route is ShellRouteBase) { |
Contributor
Author
There was a problem hiding this comment.
I considered this, but I thought this may break in future if someone writes are new concrete implementation of ShellRouteBase.
Contributor
Author
There was a problem hiding this comment.
I'm pushing changes as you suggested.
Contributor
There was a problem hiding this comment.
It should be fine as long as they follow the same contract of ShellRouteBase.
hannah-hyj
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 13, 2023
…tatefulShellRoute (flutter/packages#4177)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 13, 2023
flutter/packages@c9865e8...0507297 2023-06-12 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump com.google.guava:guava from 32.0.0-android to 32.0.1-android in /packages/camera/camera_android_camerax/android (flutter/packages#4195) 2023-06-12 [email protected] [ci] Finish migrating Pigeon tests to LUCI (flutter/packages#3192) 2023-06-12 49699333+dependabot[bot]@users.noreply.github.com [local_auth]: Bump androidx.fragment:fragment from 1.5.7 to 1.6.0 in /packages/local_auth/local_auth_android/android (flutter/packages#4186) 2023-06-12 49699333+dependabot[bot]@users.noreply.github.com [sign_in]: Bump com.google.guava:guava from 32.0.0-android to 32.0.1-android in /packages/google_sign_in/google_sign_in_android/android (flutter/packages#4184) 2023-06-12 [email protected] [go_router] Fixes a bug in `debugLogDiagnostics` to support StatefulShellRoute (flutter/packages#4177) 2023-06-12 [email protected] Roll Flutter from 3df163f to 353b8bc (10 revisions) (flutter/packages#4198) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fixes the following issue:
debugLogDiagnostics: truedoesn't outputStatefulShellRouteroutes flutter#127957Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.