-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[ci] Exclude maps unit tests on Windows #4152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Exclude maps unit tests on Windows #4152
Conversation
Now that `google_maps_flutter` supports web, add it to the list of tests that don't currently run correctly on a Windows CI host.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
ditman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
auto label is removed for flutter/packages, pr: 4152, due to - The status or check suite android-platform_tests CHANNEL:master PACKAGE_SHARDING:--shardIndex 3 --shardCount 8 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
The failure here is an unrelated OOB breakage :( It should be a one-line fix so I rolled it into this. |
flutter/packages@da72219...a84b2c2 2023-06-06 [email protected] [ci] Exclude maps unit tests on Windows (flutter/packages#4152) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Now that
google_maps_fluttersupports web, add it to the list of tests that don't currently run correctly on a Windows CI host.Also enables multidex in
local_authto fix an OOB failure from the recent publishing of local_auth_android.