Skip to content

Conversation

@stuartmorgan-g
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g commented Jun 6, 2023

Now that google_maps_flutter supports web, add it to the list of tests that don't currently run correctly on a Windows CI host.

Also enables multidex in local_auth to fix an OOB failure from the recent publishing of local_auth_android.

Now that `google_maps_flutter` supports web, add it to the list of
tests that don't currently run correctly on a Windows CI host.
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@ditman ditman self-requested a review June 6, 2023 20:52
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ditman ditman added autosubmit Merge PR when tree becomes green via auto submit App and removed needs tests labels Jun 6, 2023
@ditman ditman removed their assignment Jun 6, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 6, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 6, 2023

auto label is removed for flutter/packages, pr: 4152, due to - The status or check suite android-platform_tests CHANNEL:master PACKAGE_SHARDING:--shardIndex 3 --shardCount 8 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@stuartmorgan-g
Copy link
Collaborator Author

The failure here is an unrelated OOB breakage :( It should be a one-line fix so I rolled it into this.

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 6, 2023
@stuartmorgan-g stuartmorgan-g merged commit a84b2c2 into flutter:main Jun 6, 2023
@stuartmorgan-g stuartmorgan-g deleted the flutter-web-window-exclusion branch June 6, 2023 23:28
@stuartmorgan-g stuartmorgan-g removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 6, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 7, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants