Skip to content

[various] Add http 1.0 compatibility #4147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 4 commits into from
Jun 7, 2023
Merged

[various] Add http 1.0 compatibility #4147

auto-submit merged 4 commits into from
Jun 7, 2023

Conversation

@stuartmorgan-g
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g commented Jun 6, 2023

The http package was updated to 1.0. There are no change that affect our usage (it just adds new class restrictions), so this extends all dependencies to include both 0.13.x and 1.x.

All changes here are tool-applied (update-dependencies and update-release-info) except for the script/tools/ pubspec update, so are identical in all packages.

Fixes flutter/flutter#127926

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@stuartmorgan-g stuartmorgan-g mentioned this pull request Jun 6, 2023
Closed
11 tasks
ditman
ditman approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (Restarted a CI check that had timed out with an "Infra Issue")

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 6, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 6, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 6, 2023

auto label is removed for flutter/packages, pr: 4147, due to - The status or check suite Windows dart_unit_tests master - packages has failed. Please fix the issues identified (or deflake) before re-applying this label.

@ditman
Copy link
Member

ditman commented Jun 6, 2023 •
edited
Loading

Hm, the Windows failure seems related to failing to run Chrome tests in google_maps_flutter?

============================================================
|| Running for packages/google_maps_flutter/google_maps_flutter [@5:29]
============================================================
�[0m
Running command: "flutter.bat test --color --platform=chrome" in C:\b\s\w\ir\x\w\packages\packages\google_maps_flutter\google_maps_flutter

...

00:00 +0: compiling C:/b/s/w/ir/x/w/packages/packages/google_maps_flutter/google_maps_flutter/test/circle_updates_test.dart
00:00 +0 -1: compiling C:/b/s/w/ir/x/w/packages/packages/google_maps_flutter/google_maps_flutter/test/circle_updates_test.dart [E]
  Failed to load "C:/b/s/w/ir/x/w/packages/packages/google_maps_flutter/google_maps_flutter/test/circle_updates_test.dart":
  Failed to find ".\Google\Chrome\Application\chrome.exe" in the search path.
    Command: .\Google\Chrome\Application\chrome.exe 
  package:process/src/interface/local_process_manager.dart 56:7    LocalProcessManager.start
  package:flutter_tools/src/base/error_handling_io.dart 689:24     ErrorHandlingProcessManager.start.<fn>
  package:flutter_tools/src/base/error_handling_io.dart 559:20     _run
  package:flutter_tools/src/base/error_handling_io.dart 688:12     ErrorHandlingProcessManager.start
  package:flutter_tools/src/web/chrome.dart 260:53                 ChromiumLauncher._spawnChromiumProcess
  package:flutter_tools/src/web/chrome.dart 219:36                 ChromiumLauncher.launch
  ===== asynchronous gap ===========================
  package:flutter_tools/src/test/flutter_web_platform.dart 665:29  BrowserManager.start
  ===== asynchronous gap ===========================
  package:flutter_tools/src/test/flutter_web_platform.dart 448:25  FlutterWebPlatform.load
  ===== asynchronous gap ===========================
  package:test_core/src/runner/loader.dart 232:27                  Loader.loadFile.<fn>
  ===== asynchronous gap ===========================
  package:test_core/src/runner/load_suite.dart 98:19               new LoadSuite.<fn>.<fn>
  
00:00 +0 -1: compiling C:/b/s/w/ir/x/w/packages/packages/google_maps_flutter/google_maps_flutter/test/google_map_test.dart
00:00 +0 -2: compiling C:/b/s/w/ir/x/w/packages/packages/google_maps_flutter/google_maps_flutter/test/google_map_test.dart [E]
  TimeoutException after 0:12:00.000000: Test timed out after 12 minutes.
  package:test_api/src/backend/invoker.dart 338:28  Invoker._handleError.<fn>
  dart:async/zone.dart 1391:47                      _rootRun
  dart:async/zone.dart 1301:19                      _CustomZone.run
  package:test_api/src/backend/invoker.dart 336:10  Invoker._handleError
  package:test_api/src/backend/invoker.dart 291:9   Invoker.heartbeat.<fn>.<fn>
  dart:async/zone.dart 1399:13                      _rootRun
  dart:async/zone.dart 1301:19                      _CustomZone.run
  package:test_api/src/backend/invoker.dart 290:38  Invoker.heartbeat.<fn>
  dart:async-patch/timer_patch.dart 18:15           Timer._createTimer.<fn>
  dart:isolate-patch/timer_impl.dart 398:19         _Timer._runTimers
  dart:isolate-patch/isolate_patch.dart 189:12      _RawReceivePort._handleMessage

That shouldn't be happening, should it?

@ditman
Copy link
Member

ditman commented Jun 6, 2023

Probably needs to be added here?

(I don't understand why this didn't show up before, or is this a result of the endorsement?)

@stuartmorgan-g
Copy link
Collaborator Author

stuartmorgan-g commented Jun 6, 2023

(I don't understand why this didn't show up before, or is this a result of the endorsement?)

I'm not sure why it didn't show up in your endorsement PR, since I believe having the web plugin entry is what triggers that change. Weird.

#4152

I think the fact that it's not looking for inline implementation is probably a bug in the tooling though.

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 7, 2023
@auto-submit auto-submit bot merged commit e37dd83 into flutter:main Jun 7, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 8, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 8, 2023
@engine-flutter-autoroll
e37dd83 [various] Add http 1.0 compatibility (flutter/packages#4147)
cea047c
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jun 8, 2023
@engine-flutter-autoroll
Roll Packages from a84b2c2 to e13b8c4 (9 revisions) (#128508)
11c8a62 
flutter/packages@a84b2c2...e13b8c4

2023-06-08 [email protected] [tool] Only run unit tests in Chrome for inline web (flutter/packages#4153)
2023-06-08 [email protected] [in_app_purchase] Make the _FeatureCard constructor const in the Android example app (flutter/packages#4162)
2023-06-08 [email protected] [shared_preferences] Fix initialization race (flutter/packages#4159)
2023-06-07 [email protected] [go_router] Refactors imperative APIs and browser history (flutter/packages#4134)
2023-06-07 [email protected] [various] Add `http` 1.0 compatibility (flutter/packages#4147)
2023-06-07 [email protected] [go_router_builder] Accept required parameters not in path (flutter/packages#4039)
2023-06-07 [email protected] Roll Flutter from 0b74153 to 8a5c22e (46 revisions) (flutter/packages#4160)
2023-06-07 [email protected] [pigeon] Require analyzer 5.13.0, prepare for NamedType refactoring. (flutter/packages#4127)
2023-06-07 [email protected] Roll Flutter (stable) from f92f441 to 682aa38 (1 revision) (flutter/packages#4157)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
Merged
Closed
Merged
@reidbaker reidbaker mentioned this pull request Jul 26, 2023
Merged
11 tasks
@reidbaker reidbaker mentioned this pull request Aug 4, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ditman ditman ditman approved these changes

@tarrinneal tarrinneal tarrinneal approved these changes

@vashworth vashworth Awaiting requested review from vashworth

@camsim99 camsim99 Awaiting requested review from camsim99

@keyonghan keyonghan Awaiting requested review from keyonghan

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: extension_google_sign_in_as_googleapis_auth p: file_selector p: google_maps_flutter p: google_sign_in p: image_picker p: metrics_center platform-android platform-ios platform-web

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Google sign in version 6.1.0 requires http 0.13.5

3 participants

@stuartmorgan-g @ditman @tarrinneal