Skip to content

Conversation

@stuartmorgan-g
Copy link
Collaborator

Calling 'pub activate flutter_plugin_tools' changes the global state,
which is not something a specific package should be doing in a script
that runs on CI. This not only bypasses the pinning for this test, which
is currently causing out-of-band breakage, but also any test that runs
later.

Fixes flutter/flutter#86675

Pre-launch Checklist

  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

Calling 'pub activate flutter_plugin_tools' changes the global state,
which is not something a specific package should be doing in a script
that runs on CI. This not only bypasses the pinning for this test, which
is currently causing out-of-band breakage, but also any test that runs
later.
@stuartmorgan-g
Copy link
Collaborator Author

If you want a script that does the activate as a convenience for people running locally, then you need two separate scripts: one with core functionality that CI uses, and a wrapper for local use (as I've suggested in a previous review).

Copy link
Member

@gaaclarke gaaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! lgtm

@stuartmorgan-g stuartmorgan-g merged commit ebc0723 into flutter:master Jul 20, 2021
@stuartmorgan-g stuartmorgan-g deleted the pigeon-dont-activate-tools branch July 20, 2021 17:08
stuartmorgan-g pushed a commit that referenced this pull request Aug 27, 2025
Bumps [http](https://github.com/dart-lang/http/tree/master/pkgs) from 0.13.5 to 1.0.0.
- [Release notes](https://github.com/dart-lang/http/releases)
- [Commits](https://github.com/dart-lang/http/commits/HEAD/pkgs)

---
updated-dependencies:
- dependency-name: http
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flutter_plugin_tools can't find java from PATH

2 participants