Repository navigation
Manual roll Flutter from 216605b60f67 to 08266bdfcf11 (38 revisions) - #4084
Closed
engine-flutter-autoroll wants to merge 38 commits into
Conversation
…on keyboard shortcuts (flutter/flutter#126896)
…f94a4 to 0776a679364a9a16110aac8d0f40f5e11009e327 (flutter/flutter#127533)
…Region logic & animation (flutter/flutter#119199)
engine-flutter-autoroll
added
the
autosubmit
fluttergithubbot
approved these changes
May 25, 2023
auto-submit
Bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/packages, pr: 4084, due to - The status or check suite downgraded_analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
engine-flutter-autoroll
deleted the
flutter-packages-3c4bfc2d-ac4a-4723-95cb-a86d81a75a0e-1685050785
branch
June 1, 2023 23:10
auto-submit Bot
pushed a commit
that referenced
this pull request
Nov 2, 2026
…13528) **This PR fixes the tree.** `Linux_android custom_package_tests master` is failing on `main` (all 3 attempts of [#4084](https://ci.chromium.org/p/flutter/builders/prod/Linux_android%20custom_package_tests%20master/4084)) in the Pigeon integration test `event channels handle multiple instances`: ``` The following MissingPluginException was thrown while de-activating platform stream on channel dev.flutter.pigeon.pigeon_integration_tests.EventChannelMethods.streamConsistentNumbers.1: MissingPluginException(No implementation found for method cancel on channel dev.flutter.pigeon.pigeon_integration_tests.EventChannelMethods.streamConsistentNumbers.1) ``` ### Cause The test plugin unregisters the stream handler for instance `"1"` (to exercise event channel unregistration, added in #13438) immediately after calling `endOfStream()`. On the Dart side, the end of the stream closes the `EventChannel`'s broadcast stream, which then sends a `cancel` method call back on the same channel. If the handler has already been removed by the time that `cancel` call arrives, it fails with a `MissingPluginException`, which fails the test. Whether it fails depends on timing, so it shows up as a flake. ### Fix Unregister the handler from the stream handler's `onCancel` instead, i.e. only after the `cancel` call has been received, in both the Kotlin (Android) and Swift (iOS/macOS) test plugins. The generated Pigeon stream handler wrappers already forward the platform `onCancel` to the user handler, so no generator or generated-code changes are needed. The test still exercises unregistration; it just no longer races with the channel teardown. This only changes test plugin code under `platform_tests/`, so there is no change to the published package. ### Testing On an Android emulator (Pixel 9a), running only `event channels handle multiple instances`: | | Runs | Failures (`MissingPluginException` on `cancel`) | |---|---|---| | Without this fix (`main`) | 5 | 2 | | With this fix | 10 | 0 | The full `android_kotlin_integration_tests` suite (680 tests) also passes with this fix, as do `dart_unittests` and `flutter_unittests`. The Swift change mirrors the Kotlin one and is covered by the iOS/macOS integration tests in CI. ### Related flutter/flutter#179154 tracks a different flake in the same test on macOS Swift (`Bad state: Cannot add new events after calling close`, i.e. an event sent after `endOfStream`). This PR does not address that one, and the macOS Swift skip is left in place. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual roll Flutter from 216605b to 08266bd (38 revisions)
Manual roll requested by [email protected]
flutter/flutter@216605b...08266bd
2023-05-25 [email protected] Roll Flutter Engine from 6ff02c17268f to 99f2653cbb79 (6 revisions) (flutter/flutter#127619)
2023-05-25 [email protected]
ProcessResultMatchercreated and used in test (flutter/flutter#127414)2023-05-25 [email protected] Fix yaml lint issue (flutter/flutter#127600)
2023-05-25 [email protected] Roll Flutter Engine from 515a4bfc4b6e to 6ff02c17268f (1 revision) (flutter/flutter#127609)
2023-05-25 [email protected]
SearchBarshould not be impacted by overallInputDecorationTheme(flutter/flutter#127465)2023-05-25 [email protected] Roll Flutter Engine from 195009b91abd to 515a4bfc4b6e (4 revisions) (flutter/flutter#127601)
2023-05-25 [email protected] Roll Flutter Engine from fb463217d1f3 to 195009b91abd (1 revision) (flutter/flutter#127591)
2023-05-25 [email protected] avoid incorrect usage of TimelineTask (flutter/flutter#127527)
2023-05-25 [email protected] Add
ScrollNotificationObserversample (flutter/flutter#127023)2023-05-25 [email protected] Roll Packages from fba97fa to 995bfc5 (3 revisions) (flutter/flutter#127590)
2023-05-25 [email protected] Roll Flutter Engine from a74d9d1f4776 to fb463217d1f3 (1 revision) (flutter/flutter#127577)
2023-05-25 [email protected] Roll Flutter Engine from a7f026b03e35 to a74d9d1f4776 (1 revision) (flutter/flutter#127565)
2023-05-25 [email protected] Roll Flutter Engine from fb38bb6b1bc1 to a7f026b03e35 (1 revision) (flutter/flutter#127563)
2023-05-25 [email protected] Roll Flutter Engine from 2be736c390ee to fb38bb6b1bc1 (1 revision) (flutter/flutter#127560)
2023-05-25 [email protected] Remove Tooltip mouse tracker listener & update hovering/MouseRegion logic & animation (flutter/flutter#119199)
2023-05-25 [email protected] Roll Flutter Engine from 37ebad2d5c27 to 2be736c390ee (2 revisions) (flutter/flutter#127554)
2023-05-25 [email protected] Roll Flutter Engine from 62a83490ee60 to 37ebad2d5c27 (1 revision) (flutter/flutter#127551)
2023-05-25 [email protected] Roll Flutter Engine from 1bed04a4375a to 62a83490ee60 (3 revisions) (flutter/flutter#127546)
2023-05-25 [email protected] Roll Flutter Engine from 6a361090a367 to 1bed04a4375a (2 revisions) (flutter/flutter#127544)
2023-05-25 [email protected] Roll Flutter Engine from 9ba461efd3fe to 6a361090a367 (3 revisions) (flutter/flutter#127542)
2023-05-24 [email protected] Revert "Update labeler action wildcards" (flutter/flutter#127541)
2023-05-24 [email protected] [web] ui.platformViewRegistry => ui_web.platformViewRegistry (flutter/flutter#127493)
2023-05-24 [email protected] Roll Flutter Engine from c641f6307f08 to 9ba461efd3fe (6 revisions) (flutter/flutter#127536)
2023-05-24 [email protected] Add missing parameters in
TextFormField(flutter/flutter#127020)2023-05-24 [email protected] Update labeler action wildcards (flutter/flutter#127524)
2023-05-24 [email protected] Improve
TextPainter.layoutcaching (flutter/flutter#118128)2023-05-24 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 2713f7303c96cb1e69627957ec16eea0fd7f94a4 to 0776a679364a9a16110aac8d0f40f5e11009e327 (flutter/flutter#127533)
2023-05-24 [email protected] Fix ScrollPosition overscroll precision error (flutter/flutter#127321)
2023-05-24 [email protected]
Slider.onChangeStart&Slider.onChangeEndare not called on keyboard shortcuts (flutter/flutter#126896)2023-05-24 [email protected] Manually roll Flutter Engine from 0c41b02cd5a6 to c641f6307f08 (flutter/flutter#127514)
2023-05-24 [email protected] Update CP template to include timeline and changelog (flutter/flutter#127507)
2023-05-24 [email protected] make
suggestionsBuilderinSearchAnchorasyncable (flutter/flutter#127019)2023-05-24 [email protected] Log all lines from ios-deploy (flutter/flutter#127502)
2023-05-24 [email protected] Revert "Replace rsync when unzipping artifacts on a Mac (#126703)" (flutter/flutter#127430)
2023-05-24 [email protected] test owners: cyanglaz -> vashworth (flutter/flutter#127391)
2023-05-24 [email protected] [Linux] Ignore deprecation of libupower call in example (flutter/flutter#127503)
2023-05-24 [email protected] Roll Packages from d449a17 to fba97fa (4 revisions) (flutter/flutter#127492)
2023-05-24 [email protected] Roll Flutter Engine from eebcf36cd38f to 0c41b02cd5a6 (1 revision) (flutter/flutter#127461)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
...