Skip to content

Append $flutter/osx sdk property to existing platforms/targets relying on xcode #4074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
May 25, 2023
Merged

Append $flutter/osx sdk property to existing platforms/targets relying on xcode #4074

auto-submit merged 1 commit into from
May 25, 2023

Conversation

@keyonghan
Copy link
Contributor

@keyonghan keyonghan commented May 24, 2023

@keyonghan keyonghan mentioned this pull request May 25, 2023
Closed
@keyonghan
Copy link
Contributor Author

keyonghan commented May 25, 2023

Friendly ping. This is a no-op for existing workflows.

ricardoamador
ricardoamador approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@ricardoamador ricardoamador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keyonghan
Copy link
Contributor Author

keyonghan commented May 25, 2023

Hi @stuartmorgan, what is the process to land PRs on red for packages repo? Seems the tree has been red the whole day. This PR is a no-op config change. Is it feasible to land manually, or do I need to wait for the tree green? If one has to wait, where can I track the status of the tree? Is there a bug tracking the tree fix?

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label May 25, 2023
@godofredoc
Copy link
Contributor

godofredoc commented May 25, 2023

Hi @stuartmorgan, what is the process to land PRs on red for packages repo? Seems the tree has been red the whole day. This PR is a no-op config change. Is it feasible to land manually, or do I need to wait for the tree green? If one has to wait, where can I track the status of the tree? Is there a bug tracking the tree fix?

Tree is green!

@auto-submit auto-submit bot merged commit 9f8dcc5 into flutter:main May 25, 2023
@keyonghan keyonghan mentioned this pull request May 25, 2023
Closed
14 tasks
@stuartmorgan-g
Copy link
Collaborator

stuartmorgan-g commented May 26, 2023

Hi @stuartmorgan, what is the process to land PRs on red for packages repo?

It's the same as the other repos: only do it if your PR is fixing the breakage.

Seems the tree has been red the whole day.

We're having a fair amount of flake that we need to resolve, so it's red on and off a lot recently, but it definitely hasn't been red for the entire day. autosubmit is the best way to land things, as it'll generally land as soon as flake resolves.

If one has to wait, where can I track the status of the tree? Is there a bug tracking the tree fix?

The ecosystem channel in Discord is the best place to ask about tree issues.

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 26, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 26, 2023
@engine-flutter-autoroll
9f8dcc5 Append $flutter/osx sdk property to existing platforms/target…
7948d4f 
…s relying on xcode (flutter/packages#4074)
@keyonghan
Copy link
Contributor Author

keyonghan commented May 26, 2023

Hi @stuartmorgan, what is the process to land PRs on red for packages repo?

It's the same as the other repos: only do it if your PR is fixing the breakage.

Seems the tree has been red the whole day.

We're having a fair amount of flake that we need to resolve, so it's red on and off a lot recently, but it definitely hasn't been red for the entire day. autosubmit is the best way to land things, as it'll generally land as soon as flake resolves.

I see. Most likely the times I checked the tree was red due to flake. Will use autosubmit next time.

If one has to wait, where can I track the status of the tree? Is there a bug tracking the tree fix?

The ecosystem channel in Discord is the best place to ask about tree issues.

Cool. TIL the ecosystem channel for packages tree discussion. Will reach out there in the future.

Thanks @stuartmorgan for the info.!

auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 26, 2023
@engine-flutter-autoroll
Roll Packages from 995bfc5 to 9f8dcc5 (4 revisions) (#127671)
ee162e4 
flutter/packages@995bfc5...9f8dcc5

2023-05-25 [email protected] Append $flutter/osx sdk property to existing platforms/targets relying on xcode (flutter/packages#4074)
2023-05-25 [email protected] [url_launcher_android] Fix `unawaited_futures` lint errors (flutter/packages#4086)
2023-05-25 [email protected] [url_launcher] Convert Android to Pigeon (flutter/packages#4045)
2023-05-25 [email protected] [multiple packages] Update collection-fors to prefer final (as per updated `prefer_final_in_for_each`) (flutter/packages#4073)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
Merged
Closed
Merged
@reidbaker reidbaker mentioned this pull request Jul 26, 2023
Merged
11 tasks
@reidbaker reidbaker mentioned this pull request Aug 4, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ricardoamador ricardoamador ricardoamador approved these changes

@godofredoc godofredoc godofredoc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@keyonghan @godofredoc @stuartmorgan-g @ricardoamador