[in_app_purchase] Fix Java lints #4032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes lint-baseline.xml, fixing all resulting warnings. Also makes some fixes that weren't flagged by the command-line lint, but were flagged by Android Studio's linter, to reduce the noise in the UI. This includes all of the conversions of anonymous subclasses to lambdas, which were entirely tool-generated. Part of flutter/flutter#88011
15 tasks
gmackall
reviewed
May 19, 2023
|
|
||
| @Override | ||
| public void onMethodCall(MethodCall call, MethodChannel.Result result) { | ||
| public void onMethodCall(@NonNull MethodCall call, @NonNull MethodChannel.Result result) { |
Member
There was a problem hiding this comment.
It looks like some of the unit tests are failing with an IllegalArgumentException on calls to onMethodCall.
I've had some difficulties getting the these tests to run locally, but given that the only change was to add @nonnull I'm assuming that some of the tests were passing in null somehow?
Member
There was a problem hiding this comment.
Hmm the tests are definitely not passing in null. I've confirmed that the tests succeed on the commit before this one and not on this one, but I'm somewhat at a loss as to what in these changes could cause this error:
Please provide Old SKU purchase information(token/id) or original external transaction id, not both.
java.lang.IllegalArgumentException: Please provide Old SKU purchase information(token/id) or original external transaction id, not both.
at com.android.billingclient.api.BillingFlowParams$SubscriptionUpdateParams$Builder.build(com.android.billingclient:billing@@5.2.0:7)
at com.android.billingclient.api.BillingFlowParams$Builder.build(com.android.billingclient:billing@@5.2.0:42)
at io.flutter.plugins.inapppurchase.MethodCallHandlerImpl.launchBillingFlow(MethodCallHandlerImpl.java:331)
at io.flutter.plugins.inapppurchase.MethodCallHandlerImpl.onMethodCall(MethodCallHandlerImpl.java:150)
at io.flutter.plugins.inapppurchase.MethodCallHandlerTest.launchBillingFlow_null_AccountId_do_not_crash(MethodCallHandlerTest.java:292)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
...
Collaborator
Author
There was a problem hiding this comment.
It turns out it was the removal of TextUtils.java; AS thought it was unused, but apparently that's not true. I thought since the test compiled we no longer needed it (what I had found about that file was discussion of adding it to prevent exceptions when calling isEmpty in unit tests), but apparently the implementation used in tests was just always returning false? That would explain the observed behavior, even though it seems crazy.
stuartmorgan-g
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/packages, pr: 4032, due to This PR has not met approval requirements for merging. You are a member of flutter-hackers and need 1 more review(s) in order to merge this PR.
|
Collaborator
Author
|
Oops, I forget this hadn't actually been LGTM 😬 auto-submit bot for the win! |
gmackall
approved these changes
May 23, 2023
Member
gmackall
left a comment
gmackall
left a comment
There was a problem hiding this comment.
Oops, I forget this hadn't actually been LGTM 😬 auto-submit bot for the win!
Was actually right about to approve, LGTM!
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 24, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 24, 2023
flutter/packages@d449a17...fba97fa 2023-05-24 [email protected] Update infra reviewers and add label. (flutter/packages#4068) 2023-05-23 [email protected] [in_app_purchase] Bump `in_app_purchase_android` dependency to 3.0.0 (flutter/packages#4065) 2023-05-23 [email protected] [in_app_purchase] Fix Java lints (flutter/packages#4032) 2023-05-23 [email protected] Roll Flutter from 3437189 to f86c529 (22 revisions) (flutter/packages#4066) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
flutter/packages@d449a17...fba97fa 2023-05-24 [email protected] Update infra reviewers and add label. (flutter/packages#4068) 2023-05-23 [email protected] [in_app_purchase] Bump `in_app_purchase_android` dependency to 3.0.0 (flutter/packages#4065) 2023-05-23 [email protected] [in_app_purchase] Fix Java lints (flutter/packages#4032) 2023-05-23 [email protected] Roll Flutter from 3437189 to f86c529 (22 revisions) (flutter/packages#4066) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes lint-baseline.xml, fixing all resulting warnings.
Also makes some fixes that weren't flagged by the command-line lint, but were flagged by Android Studio's linter, to reduce the noise in the UI. This includes all of the conversions of anonymous subclasses to lambdas, which were entirely tool-generated.
Part of flutter/flutter#88011
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).