Skip to content

[various] Update minimum Flutter version to 3.3 #3967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 6 commits into from
May 12, 2023
Merged

[various] Update minimum Flutter version to 3.3 #3967

auto-submit merged 6 commits into from
May 12, 2023

Conversation

@stuartmorgan-g
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g commented May 11, 2023

Updates version-related checks for the 3.10 release:

  • Updates the N-1 and N-2 tests to 3.3 and 3.7.
  • Updates the minimum allowed SDK to declare support for to 3.3, matching our test matrix
  • Updates all packages that were supporting <3.3 to 3.3 (and equivalent Dart versions for non-Flutter packages)
  • Adds a Flutter->Dart mapping for 3.10 in the repo tooling.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@stuartmorgan-g stuartmorgan-g added the override: no versioning needed Override the check requiring version bumps for most changes label May 11, 2023
chunhtai
chunhtai approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label May 11, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented May 12, 2023

auto label is removed for flutter/packages, pr: 3967, Pull request flutter/packages/3967 is not in a mergeable state..

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 12, 2023
@tarrinneal tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label May 12, 2023
@auto-submit auto-submit bot merged commit 7319ca8 into flutter:main May 12, 2023
@reidbaker reidbaker mentioned this pull request May 12, 2023
Merged
11 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 15, 2023
@engine-flutter-autoroll
7319ca8 [various] Update minimum Flutter version to 3.3 (flutter/pack…
f0ae331 
…ages#3967)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 15, 2023
@engine-flutter-autoroll
7319ca8 [various] Update minimum Flutter version to 3.3 (flutter/pack…
28710aa 
…ages#3967)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 15, 2023
@engine-flutter-autoroll
7319ca8 [various] Update minimum Flutter version to 3.3 (flutter/pack…
27d79a2 
…ages#3967)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 15, 2023
@engine-flutter-autoroll
Roll Packages from 6328cfb to 6608b60 (22 revisions) (#126865)
96580f5 
flutter/packages@6328cfb...6608b60

2023-05-15 [email protected] [ci] Remove unnecessary Linux libraries (flutter/packages#3975)
2023-05-15 [email protected] [ci] Enforce a minimum Kotlin version in examples (flutter/packages#3979)
2023-05-15 [email protected] [ci] Disable Windows repo tool tests (flutter/packages#3980)
2023-05-12 [email protected] [ci] Add LUCI repo tool tests (flutter/packages#3964)
2023-05-12 [email protected] [url_launcher] Set broadcast reciever visability as required by target api 34 (flutter/packages#3973)
2023-05-12 [email protected] Update build.gradle with a comment explaining version (flutter/packages#3972)
2023-05-12 [email protected] Roll Flutter from 8c5a1ea to a76dbe4 (12 revisions) (flutter/packages#3958)
2023-05-12 [email protected] [image_picker] Fix Android lints (flutter/packages#3887)
2023-05-12 [email protected] [various] Update minimum Flutter version to 3.3 (flutter/packages#3967)
2023-05-12 [email protected] [tool] Target specific Android unit tests (flutter/packages#3955)
2023-05-12 [email protected] [camerax] Add a dependency on kotlin-bom to align versions of kotlin-stdlib (flutter/packages#3960)
2023-05-12 [email protected] [local_auth] Improve iOS test DI (flutter/packages#3959)
2023-05-12 [email protected] [ci] Ensure scripts fail if a command fails (flutter/packages#3963)
2023-05-11 [email protected] [ci] Pin the Flutter version for `release` (flutter/packages#3965)
2023-05-11 [email protected] [video_player] foundation - reduce seek accuracy to fix seek to end bug (flutter/packages#3784)
2023-05-11 [email protected] [image_picker] Fix use_build_context_synchronously violations (flutter/packages#3969)
2023-05-11 [email protected] [tool] Ensure that publish credential path is available (flutter/packages#3970)
2023-05-11 [email protected] [go_router] change `fix_data.yaml` uris to be absolute to fix lints (flutter/packages#3877)
2023-05-11 [email protected] [tool] Use new pub cache location for publish (flutter/packages#3962)
2023-05-10 [email protected] Roll Flutter (stable) from f72efea to 84a1e90 (1920 revisions) (flutter/packages#3961)
2023-05-10 [email protected] [image_picker_android] Improved Bitmap resize on Android (flutter/packages#3423)
2023-05-10 [email protected] [camerax] Add Kotlin duplicate classes known error to README.md (flutter/packages#3957)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@engine-flutter-autoroll
Roll Packages from 6328cfb to 6608b60 (22 revisions) (flutter#126865)
e39437c 
flutter/packages@6328cfb...6608b60

2023-05-15 [email protected] [ci] Remove unnecessary Linux libraries (flutter/packages#3975)
2023-05-15 [email protected] [ci] Enforce a minimum Kotlin version in examples (flutter/packages#3979)
2023-05-15 [email protected] [ci] Disable Windows repo tool tests (flutter/packages#3980)
2023-05-12 [email protected] [ci] Add LUCI repo tool tests (flutter/packages#3964)
2023-05-12 [email protected] [url_launcher] Set broadcast reciever visability as required by target api 34 (flutter/packages#3973)
2023-05-12 [email protected] Update build.gradle with a comment explaining version (flutter/packages#3972)
2023-05-12 [email protected] Roll Flutter from 8c5a1ea to a76dbe4 (12 revisions) (flutter/packages#3958)
2023-05-12 [email protected] [image_picker] Fix Android lints (flutter/packages#3887)
2023-05-12 [email protected] [various] Update minimum Flutter version to 3.3 (flutter/packages#3967)
2023-05-12 [email protected] [tool] Target specific Android unit tests (flutter/packages#3955)
2023-05-12 [email protected] [camerax] Add a dependency on kotlin-bom to align versions of kotlin-stdlib (flutter/packages#3960)
2023-05-12 [email protected] [local_auth] Improve iOS test DI (flutter/packages#3959)
2023-05-12 [email protected] [ci] Ensure scripts fail if a command fails (flutter/packages#3963)
2023-05-11 [email protected] [ci] Pin the Flutter version for `release` (flutter/packages#3965)
2023-05-11 [email protected] [video_player] foundation - reduce seek accuracy to fix seek to end bug (flutter/packages#3784)
2023-05-11 [email protected] [image_picker] Fix use_build_context_synchronously violations (flutter/packages#3969)
2023-05-11 [email protected] [tool] Ensure that publish credential path is available (flutter/packages#3970)
2023-05-11 [email protected] [go_router] change `fix_data.yaml` uris to be absolute to fix lints (flutter/packages#3877)
2023-05-11 [email protected] [tool] Use new pub cache location for publish (flutter/packages#3962)
2023-05-10 [email protected] Roll Flutter (stable) from f72efea to 84a1e90 (1920 revisions) (flutter/packages#3961)
2023-05-10 [email protected] [image_picker_android] Improved Bitmap resize on Android (flutter/packages#3423)
2023-05-10 [email protected] [camerax] Add Kotlin duplicate classes known error to README.md (flutter/packages#3957)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
Merged
Closed
Merged
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@stuartmorgan-g @nploi
[various] Update minimum Flutter version to 3.3 (flutter#3967)
b85536d 
Updates version-related checks for the 3.10 release:
- Updates the N-1 and N-2 tests to 3.3 and 3.7.
- Updates the minimum allowed SDK to declare support for to 3.3, matching our test matrix
- Updates all packages that were supporting <3.3 to 3.3 (and equivalent Dart versions for non-Flutter packages)
- Adds a Flutter->Dart mapping for 3.10 in the repo tooling.
@reidbaker reidbaker mentioned this pull request Jul 26, 2023
Merged
11 tasks
@reidbaker reidbaker mentioned this pull request Aug 4, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yjbanov yjbanov yjbanov approved these changes

@cbracken cbracken cbracken approved these changes

@gspencergoog gspencergoog gspencergoog approved these changes

@chunhtai chunhtai chunhtai approved these changes

@tarrinneal tarrinneal tarrinneal approved these changes

@hellohuanlin hellohuanlin Awaiting requested review from hellohuanlin hellohuanlin is a code owner

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

@LouiseHsu LouiseHsu Awaiting requested review from LouiseHsu LouiseHsu is a code owner

@vashworth vashworth Awaiting requested review from vashworth vashworth is a code owner

@reidbaker reidbaker Awaiting requested review from reidbaker reidbaker is a code owner

@camsim99 camsim99 Awaiting requested review from camsim99 camsim99 is a code owner

@ditman ditman Awaiting requested review from ditman ditman is a code owner

@MitchellGoodwin MitchellGoodwin Awaiting requested review from MitchellGoodwin MitchellGoodwin is a code owner

@jonahwilliams jonahwilliams Awaiting requested review from jonahwilliams

@Hixie Hixie Awaiting requested review from Hixie Hixie is a code owner

@bparrishMines bparrishMines Awaiting requested review from bparrishMines bparrishMines is a code owner

@goderbauer goderbauer Awaiting requested review from goderbauer

@Piinks Piinks Awaiting requested review from Piinks

+1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App override: no versioning needed Override the check requiring version bumps for most changes p: animations p: camera p: cross_file p: css_colors p: cupertino_icons p: dynamic_layouts The dynamic_layouts package p: espresso p: extension_google_sign_in_as_googleapis_auth p: file_selector p: flutter_image p: flutter_lints p: flutter_plugin_android_lifecycle p: flutter_template_images p: go_router_builder p: google_maps_flutter p: google_sign_in p: image_picker p: in_app_purchase p: ios_platform_images p: local_auth p: multicast_dns p: palette_generator p: path_provider p: pointer_interceptor p: quick_actions p: rfw Remote Flutter Widgets p: shared_preferences p: standard_message_codec p: url_launcher p: video_player p: web_benchmarks p: xdg_directories platform-android platform-ios platform-linux platform-macos platform-web platform-windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@stuartmorgan-g @yjbanov @cbracken @dnfield @gspencergoog @chunhtai @tarrinneal