Skip to content

[pigeon] Ignore deprecated name #3953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
May 10, 2023
Merged

[pigeon] Ignore deprecated name #3953

auto-submit merged 1 commit into from
May 10, 2023

Conversation

@stuartmorgan-g
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g commented May 10, 2023

Ignores a field deprecated in the latest analyzer update, causing out-of-band analyzer failures.

This is ignored for now rather than replaced to avoid dropping currently-supported Flutter versions in Pigeon right now.

Fixes flutter/flutter#126393

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@stuartmorgan-g
[pigeon] Ignore deprecated name
8c80edd 
Ignores a field deprecated in the latest `analyzer` update, causing
out-of-band analyzer failures.

This is ignored for now rather than replaced to avoid dropping
currently-supported Flutter versions in Pigeon right now.

Fixes flutter/flutter#126393
@stuartmorgan-g stuartmorgan-g added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels May 10, 2023
goderbauer
goderbauer approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g
Copy link
Collaborator Author

stuartmorgan-g commented May 10, 2023

Landing on red to fix trees.

@stuartmorgan-g stuartmorgan-g added emergency Override tree-status signal (land even with closed tree), combine with the autosubmit label. autosubmit Merge PR when tree becomes green via auto submit App labels May 10, 2023
@auto-submit auto-submit bot merged commit 0167d83 into flutter:main May 10, 2023
@reidbaker reidbaker mentioned this pull request May 12, 2023
Merged
11 tasks
This was referenced Jul 7, 2023
Merged
Closed
Merged
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@stuartmorgan-g @nploi
[pigeon] Ignore deprecated name (flutter#3953)
028c112 
Ignores a field deprecated in the latest `analyzer` update, causing out-of-band analyzer failures.

This is ignored for now rather than replaced to avoid dropping currently-supported Flutter versions in Pigeon right now.

Fixes flutter/flutter#126393
@reidbaker reidbaker mentioned this pull request Jul 26, 2023
Merged
11 tasks
@reidbaker reidbaker mentioned this pull request Aug 4, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

@tarrinneal tarrinneal Awaiting requested review from tarrinneal tarrinneal is a code owner

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App emergency Override tree-status signal (land even with closed tree), combine with the autosubmit label. override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: pigeon

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tree closed on new pigeon analyzer lint

2 participants

@stuartmorgan-g @goderbauer