-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[various] Remove iOS 9 references #3948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Runs iOS builds with current stable, landing the auto-migration changes. This includes automatically updating the example apps to require iOS 11+. - Updates the pigeon test plugins to only support iOS 11+.
|
Overriding CHANGELOG check; the build target changes here are uninteresting to clients. |
ditman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, all the changes look similar to each other. If CI is happy, I'm happy!
Piinks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
flutter/packages@0167d83...6328cfb 2023-05-10 [email protected] [go_router_builder] Adds name parameter to TypedGoRoute and supports its generation. (flutter/packages#3665) 2023-05-10 [email protected] [various] Remove iOS 9 references (flutter/packages#3948) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@0167d83...6328cfb 2023-05-10 [email protected] [go_router_builder] Adds name parameter to TypedGoRoute and supports its generation. (flutter/packages#3665) 2023-05-10 [email protected] [various] Remove iOS 9 references (flutter/packages#3948) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
- Runs iOS builds with current stable, landing the auto-migration changes. This includes automatically updating the example apps to require iOS 11+. - Updates the pigeon test plugins to only support iOS 11+. The are example-/test-only changes, so don't affect clients of these packages. See flutter/flutter#101965
The are example-/test-only changes, so don't affect clients of these packages.
See flutter/flutter#101965
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).