Skip to content

Conversation

@stuartmorgan-g
Copy link
Collaborator

quick_actions part of flutter/flutter#101965.

Built the quick_actions and quick_actions_ios example projects on Flutter 3.7 and let the tool auto-migrate various Xcode project/Podfile files. (These changes don't affect plugin clients, so I used the latest stable instead of 3.3.)

Updated the minimum Flutter version of quick_actions_ios to 3.3, where the iOS minimum version was raised to 11.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

quick_actions part of flutter/flutter#101965.

Built the `quick_actions` and `quick_actions_ios` example projects on Flutter 3.7 and let the tool auto-migrate various Xcode project/Podfile files. (These changes don't affect plugin clients, so I used the latest stable instead of 3.3.)

Updated the minimum Flutter version of `quick_actions_ios` to 3.3, where
the iOS minimum version was raised to 11.
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Hixie
Copy link
Contributor

Hixie commented May 8, 2023

test-exempt: rolling dependency

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label May 8, 2023
@auto-submit auto-submit bot merged commit 98c7062 into flutter:main May 8, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 9, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 9, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 9, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 9, 2023
flutter/packages@4800d65...1f91710

2023-05-09 [email protected] [camerax] Update README with plugin overview (flutter/packages#3891)
2023-05-09 [email protected] Fix nullability in docs (flutter/packages#3876)
2023-05-08 [email protected] [tools] Check version ranges when pathifying deps (flutter/packages#3943)
2023-05-08 [email protected] [quick_actions] Update minimum iOS version to 11 (flutter/packages#3946)
2023-05-08 [email protected] [shared_preferences] Update minimum iOS version to 11 (flutter/packages#3945)
2023-05-08 [email protected] [path_provider] Update minimum iOS version to 11 (flutter/packages#3944)
2023-05-08 [email protected] Adding setup for TestInstanceManagerHostApi in zoom and exposure tests (flutter/packages#3947)
2023-05-08 [email protected] Roll Flutter from 43ac23b to 4ed1c92 (16 revisions) (flutter/packages#3942)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
quick_actions part of flutter/flutter#101965.

Built the `quick_actions` and `quick_actions_ios` example projects on Flutter 3.7 and let the tool auto-migrate various Xcode project/Podfile files. (These changes don't affect plugin clients, so I used the latest stable instead of 3.3.)

Updated the minimum Flutter version of `quick_actions_ios` to 3.3, where the iOS minimum version was raised to 11.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App needs tests p: quick_actions platform-ios

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants