-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[shared_preferences] Update minimum iOS version to 11 #3945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[shared_preferences] Update minimum iOS version to 11 #3945
Conversation
shared_preferences part of flutter/flutter#101965. Built the `shared_preferences` and `shared_preferences_foundation` example projects on Flutter 3.7 and let the tool auto-migrate various Xcode project/Podfile files. (These changes don't affect plugin clients, so I used the latest stable instead of 3.3.) No Flutter version update was necessary, as `shared_preferences_foundation` already has a minimum of 3.3.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
cyanglaz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
test-exempt: rolling dependency |
flutter/packages@4800d65...1f91710 2023-05-09 [email protected] [camerax] Update README with plugin overview (flutter/packages#3891) 2023-05-09 [email protected] Fix nullability in docs (flutter/packages#3876) 2023-05-08 [email protected] [tools] Check version ranges when pathifying deps (flutter/packages#3943) 2023-05-08 [email protected] [quick_actions] Update minimum iOS version to 11 (flutter/packages#3946) 2023-05-08 [email protected] [shared_preferences] Update minimum iOS version to 11 (flutter/packages#3945) 2023-05-08 [email protected] [path_provider] Update minimum iOS version to 11 (flutter/packages#3944) 2023-05-08 [email protected] Adding setup for TestInstanceManagerHostApi in zoom and exposure tests (flutter/packages#3947) 2023-05-08 [email protected] Roll Flutter from 43ac23b to 4ed1c92 (16 revisions) (flutter/packages#3942) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
shared_preferences part of flutter/flutter#101965. Built the `shared_preferences` and `shared_preferences_foundation` example projects on Flutter 3.7 and let the tool auto-migrate various Xcode project/Podfile files. (These changes don't affect plugin clients, so I used the latest stable instead of 3.3.) No Flutter version update was necessary, as `shared_preferences_foundation` already has a minimum of 3.3.
shared_preferences part of flutter/flutter#101965.
Built the
shared_preferencesandshared_preferences_foundationexample projects on Flutter 3.7 and let the tool auto-migrate various Xcode project/Podfile files. (These changes don't affect plugin clients, so I used the latest stable instead of 3.3.)No Flutter version update was necessary, as
shared_preferences_foundationalready has a minimum of 3.3.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).