manual roll and fix #3903
Merged
manual roll and fix #3903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarrinneal
requested review from
bparrishMines,
camsim99,
cyanglaz,
gmackall and
stuartmorgan-g
as code owners
...src/test/java/io/flutter/embedding/engine/plugins/lifecycle/FlutterLifecycleAdapterTest.java
Outdated
Show resolved
Hide resolved
bparrishMines
approved these changes
May 4, 2023
Contributor
bparrishMines
left a comment
bparrishMines
left a comment
There was a problem hiding this comment.
LGTM pending tests and removing the dependency_overrides.
...src/test/java/io/flutter/embedding/engine/plugins/lifecycle/FlutterLifecycleAdapterTest.java
Outdated
Show resolved
Hide resolved
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 5, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 5, 2023
flutter/packages@6bd59cd...a0f8fd8 2023-05-05 [email protected] tree fix (flutter/packages#3910) 2023-05-05 [email protected] manual roll and fix (flutter/packages#3903) 2023-05-04 [email protected] [file_selector] Add `getDirectoryPaths` (flutter/packages#3871) 2023-05-04 [email protected] [go_router_builder] fixed typo in README (flutter/packages#3835) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
This was referenced Jul 7, 2023
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
Manual roll with small fix to green tree --------- Co-authored-by: Maurice Parrish <[email protected]>
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual roll with small fix to green tree