Skip to content

Conversation

@justinmc
Copy link
Contributor

@justinmc justinmc commented May 1, 2023

I just noticed that these snippets didn't work out of the box. Probably they weren't updated when this package was ported to NNBD.

@justinmc justinmc self-assigned this May 1, 2023
@justinmc justinmc requested a review from stuartmorgan-g as a code owner May 1, 2023 22:31
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g
Copy link
Collaborator

This will need a version bump so the user-facing comments will get published.

@justinmc
Copy link
Contributor Author

justinmc commented May 2, 2023

Thanks! I just ran update-release-info and pushed the commit. Let me know if I'm missing anything else.

@justinmc
Copy link
Contributor Author

justinmc commented May 8, 2023

@stuartmorgan Anything else needed before this PR can merge?

@stuartmorgan-g
Copy link
Collaborator

No, all the tests are green so it's good to land.

@justinmc
Copy link
Contributor Author

justinmc commented May 9, 2023

Thanks!

@justinmc justinmc merged commit d71e5c6 into flutter:main May 9, 2023
@justinmc justinmc deleted the link-docs-fix branch May 9, 2023 16:40
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 9, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 9, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 9, 2023
flutter/packages@4800d65...1f91710

2023-05-09 [email protected] [camerax] Update README with plugin overview (flutter/packages#3891)
2023-05-09 [email protected] Fix nullability in docs (flutter/packages#3876)
2023-05-08 [email protected] [tools] Check version ranges when pathifying deps (flutter/packages#3943)
2023-05-08 [email protected] [quick_actions] Update minimum iOS version to 11 (flutter/packages#3946)
2023-05-08 [email protected] [shared_preferences] Update minimum iOS version to 11 (flutter/packages#3945)
2023-05-08 [email protected] [path_provider] Update minimum iOS version to 11 (flutter/packages#3944)
2023-05-08 [email protected] Adding setup for TestInstanceManagerHostApi in zoom and exposure tests (flutter/packages#3947)
2023-05-08 [email protected] Roll Flutter from 43ac23b to 4ed1c92 (16 revisions) (flutter/packages#3942)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
Update code in docs snippets.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants