-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Fix nullability in docs #3876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nullability in docs #3876
Conversation
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
This will need a version bump so the user-facing comments will get published. |
|
Thanks! I just ran update-release-info and pushed the commit. Let me know if I'm missing anything else. |
|
@stuartmorgan Anything else needed before this PR can merge? |
|
No, all the tests are green so it's good to land. |
|
Thanks! |
flutter/packages@4800d65...1f91710 2023-05-09 [email protected] [camerax] Update README with plugin overview (flutter/packages#3891) 2023-05-09 [email protected] Fix nullability in docs (flutter/packages#3876) 2023-05-08 [email protected] [tools] Check version ranges when pathifying deps (flutter/packages#3943) 2023-05-08 [email protected] [quick_actions] Update minimum iOS version to 11 (flutter/packages#3946) 2023-05-08 [email protected] [shared_preferences] Update minimum iOS version to 11 (flutter/packages#3945) 2023-05-08 [email protected] [path_provider] Update minimum iOS version to 11 (flutter/packages#3944) 2023-05-08 [email protected] Adding setup for TestInstanceManagerHostApi in zoom and exposure tests (flutter/packages#3947) 2023-05-08 [email protected] Roll Flutter from 43ac23b to 4ed1c92 (16 revisions) (flutter/packages#3942) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Update code in docs snippets.
I just noticed that these snippets didn't work out of the box. Probably they weren't updated when this package was ported to NNBD.