[webview_flutter_android] Adds support to accept third party cookies #3834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparrishMines
changed the title
Contributor
Author
|
cc @jjliu15 FYI |
Collaborator
Support just landed for it last month in WebKit: https://bugs.webkit.org/show_bug.cgi?id=249508 (I happened to see this go by because the very old https://bugs.webkit.org/show_bug.cgi?id=140205 was filed by my team back when I was in Chromium-land, and was dup'd against it just recently.) So we should probably go ahead and design this as a cross-platform feature and just indicate that it's not supported on iOS yet. I'm not sure how iOS branching and cutoffs work; presumably this will be in this year's iOS release if we're lucky, or next year's if not. |
Collaborator
|
Actually, hm. It looks like they maybe only added Allow and Deny at the WKWebView level, and it's not clear to me if Allow includes third-party cookies. I guess we should do this now, and revisit a cross-platform API if/when we have something final on iOS to look at. |
|
cc @malandr2 |
bparrishMines
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 3, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 3, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 3, 2023
flutter/packages@f163786...407b7da 2023-05-03 [email protected] Update Cirrus to Xcode 14.3 (flutter/packages#3890) 2023-05-03 [email protected] [file_selector] Deprecates `macUTIs` (flutter/packages#3888) 2023-05-03 [email protected] [pigeon]enable treat warning as errors for swift code in unit test (flutter/packages#3889) 2023-05-02 [email protected] Update xcode to 14e222b (flutter/packages#3868) 2023-05-02 [email protected] [pigeon]fix "as Any" workaround due to nested optional (flutter/packages#3658) 2023-05-02 [email protected] [webview_flutter_android] Adds support to accept third party cookies (flutter/packages#3834) 2023-05-02 [email protected] [webview_flutter_wkwebview] Fixes an exception caused by the `onUrlChange` callback returning a null url (flutter/packages#3848) 2023-05-02 [email protected] [google_maps_flutter] [Docs] Note regarding usage within a bounded & an unbound widget (flutter/packages#3691) 2023-05-02 [email protected] [local_auth_android] Fix Android lint warnings (flutter/packages#3764) 2023-05-02 [email protected] [go_router_builder] Support go_router v7 (flutter/packages#3858) 2023-05-02 [email protected] [webview_flutter_wkwebview] Fixes internal enum type and adds unknown enum values (flutter/packages#3812) 2023-05-02 [email protected] [file_selector] Add MIME type support on macOS (flutter/packages#3862) 2023-05-02 [email protected] Roll Flutter from 828a040 to db6074a (12 revisions) (flutter/packages#3881) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
11 tasks
This was referenced Jul 12, 2023
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
…lutter#3834) Adds support to accept third party cookies with https://developer.android.com/reference/android/webkit/CookieManager#setAcceptThirdPartyCookies(android.webkit.WebView,%20boolean) This is being added as an Android-specific method since iOS doesn't seem to have an equivalent. See https://developer.apple.com/forums/thread/701327 https://developer.apple.com/forums/thread/16847 This also updates the `CookieManager` wrapping since the `HostApi` needs to access the `InstanceManager` for this method. Fixes flutter/flutter#125569
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support to accept third party cookies with https://developer.android.com/reference/android/webkit/CookieManager#setAcceptThirdPartyCookies(android.webkit.WebView,%20boolean)
This is being added as an Android-specific method since iOS doesn't seem to have an equivalent. See
https://developer.apple.com/forums/thread/701327
https://developer.apple.com/forums/thread/16847
This also updates the
CookieManagerwrapping since theHostApineeds to access theInstanceManagerfor this method.Fixes flutter/flutter#125569
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.