Skip to content

[in_app_pur]: Bump org.mockito:mockito-core from 4.7.0 to 5.3.1 in /packages/in_app_purchase/in_app_purchase_android/android #3805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dependabot wants to merge 3 commits into from
Closed

[in_app_pur]: Bump org.mockito:mockito-core from 4.7.0 to 5.3.1 in /packages/in_app_purchase/in_app_purchase_android/android #3805

dependabot wants to merge 3 commits into from

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 24, 2023 •
edited
Loading

Bumps org.mockito:mockito-core from 4.7.0 to 5.3.1.

Release notes

Sourced from org.mockito:mockito-core's releases.

v5.3.1

Changelog generated by Shipkit Changelog Gradle Plugin

5.3.1

v5.3.0

Changelog generated by Shipkit Changelog Gradle Plugin

5.3.0

v5.2.0

Changelog generated by Shipkit Changelog Gradle Plugin

5.2.0

... (truncated)

Commits
  • baf59c4 Weakens visibility constraint for spy constructors (#2983)
  • 02b9634 Fix NPE for handling Object (#2976)
  • 6ffd23e Add ArgumentMatchers#assertArg method (#2949)
  • 203132d Add withoutAnnotations parameter to @Mock (#2965)
  • 84a5eee Fix ClassCastException regression with parameterized types with InjectMocks (...
  • d65bba7 Bump versions.bytebuddy from 1.14.3 to 1.14.4 (#2966)
  • 600eaa0 Bump com.diffplug.spotless from 6.17.0 to 6.18.0 (#2967)
  • f9fbf50 Bump org.codehaus.groovy:groovy from 3.0.16 to 3.0.17 (#2959)
  • 0b8685c Bump versions.bytebuddy from 1.14.2 to 1.14.3 (#2950)
  • 5486617 Correct visibility check to respect nestmates (#2948)
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot requested a review from gmackall as a code owner April 24, 2023 09:06
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Apr 24, 2023
@dependabot dependabot bot mentioned this pull request Apr 24, 2023
Closed
@dependabot dependabot bot force-pushed the dependabot/gradle/packages/in_app_purchase/in_app_purchase_android/android/org.mockito-mockito-core-5.3.1 branch 2 times, most recently from 0f11fcc to ae67de8 Compare April 27, 2023 20:49
@gmackall
Copy link
Member

gmackall commented May 25, 2023

@dependabot rebase

@dependabot
[in_app_pur]: Bump org.mockito:mockito-core
4a8dcfb 
Bumps [org.mockito:mockito-core](https://github.com/mockito/mockito) from 4.7.0 to 5.3.1.
- [Release notes](https://github.com/mockito/mockito/releases)
- [Commits](mockito/mockito@v4.7.0...v5.3.1)

---
updated-dependencies:
- dependency-name: org.mockito:mockito-core
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/gradle/packages/in_app_purchase/in_app_purchase_android/android/org.mockito-mockito-core-5.3.1 branch from ae67de8 to 4a8dcfb Compare May 25, 2023 15:30
@stuartmorgan-g
Copy link
Collaborator

stuartmorgan-g commented Jun 13, 2023

@gmackall It looks like this update may be breaking tests?

@gmackall
Copy link
Member

gmackall commented Jun 15, 2023

@gmackall It looks like this update may be breaking tests?

Yes, I took a brief look and wasn't sure exactly why. Will investigate and fix the tests this afternoon!

@gmackall
Copy link
Member

gmackall commented Jun 15, 2023 •
edited
Loading

It looks like these two tests (one, two) break because they are using an ArgumentCaptor for the BillingResult class, and checking the arguments passed to result.success() using that ArgumentCaptor.

But we translate the BillingResult into a HashMap before passing to result.success(), so the type is wrong. I'll put up a PR that contains this upgrade and the fix for that problem shortly.

Interesting that it worked before, it looks like something about the ArgumentCaptor class changed recently (in the 5.0.0 notes here: https://github.com/mockito/mockito/releases), so perhaps that is why the upgrade broke it.

@gmackall gmackall mentioned this pull request Jun 15, 2023
Merged
11 tasks
@gmackall
Copy link
Member

gmackall commented Jun 15, 2023

Closing in favor of #4224

@gmackall gmackall closed this Jun 15, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 15, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/gradle/packages/in_app_purchase/in_app_purchase_android/android/org.mockito-mockito-core-5.3.1 branch June 15, 2023 20:22
auto-submit bot pushed a commit that referenced this pull request Jun 22, 2023
@gmackall
[in_app_purchase_android] Bump org.mockito:mockito-core from 4.7.0 to…
48dd232 
… 5.3.1 (#4224)

Takeover of #3805.

See the comment here: #3805 (comment)

This pr also removes most usages of `@SuppressWarnings("unchecked")` in `MethodCallHandlerTest.java` by using the `@Captor` annotation to create a class level `resultCaptor`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmackall gmackall Awaiting requested review from gmackall gmackall is a code owner

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file java Pull requests that update Java code p: in_app_purchase platform-android

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gmackall @stuartmorgan-g