Skip to content

Conversation

@camsim99
Copy link
Contributor

@camsim99 camsim99 commented Apr 22, 2023

Implements off, auto, and always flash configurations for image capture.

Part of flutter/flutter#120715.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@camsim99 camsim99 changed the title Add flash configuration for image capture [camerax] Add flash configuration for image capture Apr 22, 2023
@camsim99 camsim99 closed this Jun 13, 2023
@camsim99
Copy link
Contributor Author

Will re-open when I pick back up CameraX work.

@camsim99 camsim99 reopened this Jul 13, 2023
@camsim99 camsim99 marked this pull request as ready for review July 13, 2023 23:26
@camsim99 camsim99 requested review from a team and bparrishMines July 13, 2023 23:27
Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 17, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 17, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 17, 2023

auto label is removed for flutter/packages, pr: 3800, due to Pull request flutter/packages/3800 is not in a mergeable state.

@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 17, 2023
@auto-submit auto-submit bot merged commit 228c2b1 into flutter:main Jul 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 18, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 18, 2023
flutter/packages@6889cca...3e8b813

2023-07-18 [email protected] [video_player] Fix iOS crash with multiple players (flutter/packages#4202)
2023-07-17 [email protected] [pigeon] Enable Android emulator tests in CI (flutter/packages#4484)
2023-07-17 [email protected] [video_player] Add optional web options [Platform interface] (flutter/packages#4433)
2023-07-17 [email protected] [google_maps_flutter_platform_interface] Platform interface changes for #3258 (flutter/packages#4478)
2023-07-17 [email protected] [video_player] fix: add missing isPlaybackLikelyToKeepUp check. (flutter/packages#3826)
2023-07-17 [email protected] [camerax] Add flash configuration for image capture (flutter/packages#3800)
2023-07-17 [email protected] Remove `equatable` and `xml` allowances (flutter/packages#4489)
2023-07-17 [email protected] [ci] Switch Linux platform tests to LUCI (flutter/packages#4479)
2023-07-17 [email protected] [ci] Adjust bot configurations (flutter/packages#4485)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
flutter/packages@6889cca...3e8b813

2023-07-18 [email protected] [video_player] Fix iOS crash with multiple players (flutter/packages#4202)
2023-07-17 [email protected] [pigeon] Enable Android emulator tests in CI (flutter/packages#4484)
2023-07-17 [email protected] [video_player] Add optional web options [Platform interface] (flutter/packages#4433)
2023-07-17 [email protected] [google_maps_flutter_platform_interface] Platform interface changes for flutter#3258 (flutter/packages#4478)
2023-07-17 [email protected] [video_player] fix: add missing isPlaybackLikelyToKeepUp check. (flutter/packages#3826)
2023-07-17 [email protected] [camerax] Add flash configuration for image capture (flutter/packages#3800)
2023-07-17 [email protected] Remove `equatable` and `xml` allowances (flutter/packages#4489)
2023-07-17 [email protected] [ci] Switch Linux platform tests to LUCI (flutter/packages#4479)
2023-07-17 [email protected] [ci] Adjust bot configurations (flutter/packages#4485)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: camera

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants