Skip to content

Remove describeEnum. #3753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
May 9, 2023
Merged

Remove describeEnum. #3753

auto-submit merged 2 commits into from
May 9, 2023

Conversation

@bernaferrari
Copy link
Contributor

@bernaferrari bernaferrari commented Apr 18, 2023 •
edited
Loading

I'm deprecating describeEnum on Flutter (flutter/flutter#125016).

@flutter-dashboard
Copy link

flutter-dashboard bot commented Apr 18, 2023

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Hixie
Copy link
Contributor

Hixie commented Apr 19, 2023

test-exempt: code refactor with no semantic change

@bernaferrari bernaferrari mentioned this pull request Apr 25, 2023
Merged
cyanglaz
cyanglaz approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like there are some conflicts in CHANGELOG and pubspec.

@bernaferrari
Copy link
Contributor Author

bernaferrari commented May 8, 2023

Thanks. I fixed them. Feel free to autosubmit. Cirrus is failing for some reason, I'm not sure if it is expected or not.

@cyanglaz cyanglaz added the autosubmit Merge PR when tree becomes green via auto submit App label May 9, 2023
@auto-submit auto-submit bot merged commit b2d62c2 into flutter:main May 9, 2023
@bernaferrari bernaferrari deleted the describeEnum branch May 9, 2023 17:30
@reidbaker reidbaker mentioned this pull request May 12, 2023
Merged
11 tasks
This was referenced Jul 7, 2023
Merged
Closed
Merged
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@bernaferrari @nploi
Remove describeEnum. (flutter#3753)
a4e9361 
I'm deprecating `describeEnum` on Flutter (flutter/flutter#125016).
@reidbaker reidbaker mentioned this pull request Jul 26, 2023
Merged
11 tasks
@reidbaker reidbaker mentioned this pull request Aug 4, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@domesticmouse domesticmouse Awaiting requested review from domesticmouse

1 more reviewer

@cyanglaz cyanglaz cyanglaz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App needs tests p: flutter_markdown p: webview_flutter platform-ios

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bernaferrari @Hixie @cyanglaz