Skip to content

Conversation

@piedcipher
Copy link
Member

@piedcipher piedcipher commented Apr 10, 2023

fix a broken link in the example of image_picker.

broken-link: https://pub.dev/packages/image_picker#getting-ready-for-the-web-platform

correct-link: https://pub.dev/packages/image_picker_for_web#limitations-on-the-web-platform

fixes: flutter/flutter#111556

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@piedcipher
Copy link
Member Author

piedcipher commented Apr 10, 2023

I'm not sure if a version bump is required here hence I didn't do it.

Since my pr didn't fall under exceptions I did version bump. Also since bot didn't complaint about tests I ticked the following:

I added new tests to check the change I am making, or this PR is test-exempt.

Note: There exists a NEXT entry in the image_picker's changelog.

I've remove the NEXT entry and added it to version bump.

@piedcipher piedcipher changed the title [image_picker] [example] fix broken link for image_picker_for_web [image_picker] [example] fix broken link for image_picker_for_web in image_picker example Apr 10, 2023
Copy link
Contributor

@tarrinneal tarrinneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! tagging @stuartmorgan for second review

Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 11, 2023
@auto-submit auto-submit bot merged commit 0d7c40f into flutter:main Apr 11, 2023
@piedcipher piedcipher deleted the fix/image_picker_web_example_broken_link branch April 11, 2023 14:39
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 11, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 11, 2023
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
…image_picker example (flutter#3678)

[image_picker] [example] fix broken link for image_picker_for_web in image_picker example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: image_picker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[image_picker] Example contains a broken link

3 participants