Skip to content

[google_sign_in] Adds Google Sign In button (web). #3642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 5 commits into from
Apr 6, 2023
Merged

[google_sign_in] Adds Google Sign In button (web). #3642

auto-submit merged 5 commits into from
Apr 6, 2023

Conversation

@ditman
Copy link
Member

@ditman ditman commented Apr 4, 2023 •
edited
Loading

This PR updates plugin to separate Authentication and Authorization.

This separation enables us to add the new Google Sign In button log-in mechanism on the web.

  • Exposes new 'canAccessScopes' method.
  • Updates example to handle isSignedIn and isAuthorized separately, as needed.
    • On the web, replaces the homebrew Sign In button with the new Sign In Button widget (implemented with conditional exports).
    • Add comments to the app so it's easier to follow.
  • Document changes in the README.

Testing

Issues

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ditman ditman requested a review from stuartmorgan-g as a code owner April 4, 2023 19:03
ditman
ditman commented Apr 4, 2023
View reviewed changes
stuartmorgan-g
stuartmorgan-g reviewed Apr 5, 2023
View reviewed changes
ditman added 2 commits April 5, 2023 17:24
@ditman
[google_sign_in] Updates plugin to separate AuthN and AuthZ.
ab6e268 
* Exposes new 'canAccessScopes' method.
* Updates example to handle isSignedIn and isAuthorized separately.
  * On the web, uses the new Sign In Button API.
  * (Implemented through conditional imports)
  * Add comments to the app so it's easier to follow.
* Document changes in the README.
@ditman
Update deps, versions and example.
57cd228
@ditman ditman force-pushed the gsi-button-core branch from 674a52e to 57cd228 Compare April 6, 2023 00:40
@ditman ditman requested a review from stuartmorgan-g April 6, 2023 01:40
@ditman
Copy link
Member Author

ditman commented Apr 6, 2023

PTAL @stuartmorgan, I think I addressed your comments!

This was referenced Apr 6, 2023
Closed
Closed
stuartmorgan-g
stuartmorgan-g approved these changes Apr 6, 2023
View reviewed changes
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 6, 2023
@auto-submit auto-submit bot merged commit 7b78d15 into flutter:main Apr 6, 2023
@ditman ditman deleted the gsi-button-core branch April 6, 2023 23:07
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 7, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 7, 2023
@engine-flutter-autoroll
7b78d15 [google_sign_in] Adds Google Sign In button (web). (flutter/p…
2c570a2 
…ackages#3642)
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@ditman @nploi
[google_sign_in] Adds Google Sign In button (web). (flutter#3642)
acffdc7 
[google_sign_in] Adds Google Sign In button (web).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: google_sign_in platform-web

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[google_sign_in_web] Display Sign In With Google button

2 participants

@ditman @stuartmorgan-g