-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Update to the latest pigeon #3561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The current version is incompatible with the latest `analyzer`, which is a blocker for getting the latest `mockito`, which is a blocker for getting the latest `test_api`, which is pinned by `flutter_test` and will be breaking in the next package roll.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
|
|
Never mind, I forgot this is still |
gmackall
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I've also actually tried running the sample app with the generated code from this version of pigeon already (because I was curious about the generated FlutterError exception in 9.1.0), and I didn't run into any issues.
It doesn't do anything unless you use it. You can throw it instead of a generic |
|
test-exempt: dependency roll |
Yes, I didn't realize that the |
|
If you're returning any errors in camerax, I definitely recommend updating to using |
Update to the latest pigeon
The current version is incompatible with the latest
analyzer, which is a blocker for getting the latestmockito, which is a blocker for getting the latesttest_api, which is pinned byflutter_testand will be breaking in the next package roll.