Skip to content

[camerax] Fix CameraInfo cast causing failure in integration test #3558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 4 commits into from
Mar 27, 2023
Merged

[camerax] Fix CameraInfo cast causing failure in integration test #3558

auto-submit merged 4 commits into from
Mar 27, 2023

Conversation

@camsim99
Copy link
Contributor

@camsim99 camsim99 commented Mar 27, 2023 •
edited
Loading

Fixes a cast causing a post-submit failure for the Flutter roll into packages: https://github.com/flutter/packages/runs/12290760669.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Mar 27, 2023

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

stuartmorgan-g
stuartmorgan-g approved these changes Mar 27, 2023
View reviewed changes
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Do we know how a roll broke this?

@camsim99
Copy link
Contributor Author

camsim99 commented Mar 27, 2023

Do we know how a roll broke this?

I'm actually confused about this, but this test started breaking for me late last week after making no changes to anything related (except maybe run the test with the master Flutter branch, which I'm guessing may be the common thread). The integration test also passes on one device, but not the other. Because of that, my guess is that it's something with Dart but I'm not sure if that makes sense...

@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 27, 2023
@camsim99
Copy link
Contributor Author

camsim99 commented Mar 27, 2023

Also, @stuartmorgan is this going to be able to land or will submit-queue block it?

@stuartmorgan-g stuartmorgan-g added the emergency Override tree-status signal (land even with closed tree), combine with the autosubmit label. label Mar 27, 2023
@stuartmorgan-g
Copy link
Collaborator

stuartmorgan-g commented Mar 27, 2023

The warning: land on red to fix tree breakage label will allow autosubmit to land into a red tree, for cases like this one.

@auto-submit auto-submit bot merged commit 5ede495 into flutter:main Mar 27, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 28, 2023
@engine-flutter-autoroll
5ede495 [camerax] Fix CameraInfo cast causing failure in integration …
95e2584 
…test (flutter/packages#3558)
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@camsim99 @nploi
[camerax] Fix CameraInfo cast causing failure in integration test (fl…
3580df5 
…utter#3558)

[camerax] Fix CameraInfo cast causing failure in integration test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@reidbaker reidbaker Awaiting requested review from reidbaker

@gmackall gmackall Awaiting requested review from gmackall

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App emergency Override tree-status signal (land even with closed tree), combine with the autosubmit label. p: camera

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@camsim99 @stuartmorgan-g