Skip to content

[webview_flutter_wkwebview] Switch to quotation imports #3511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Mar 22, 2023
Merged

[webview_flutter_wkwebview] Switch to quotation imports #3511

auto-submit merged 3 commits into from
Mar 22, 2023

Conversation

@bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Mar 21, 2023 •
edited
Loading

It seems that quotation imports are required internally, so this switches the webview-umbrella.h to use them.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@bparrishMines bparrishMines requested a review from cyanglaz as a code owner March 21, 2023 20:37
@flutter-dashboard
Copy link

flutter-dashboard bot commented Mar 21, 2023

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@bparrishMines bparrishMines changed the title use quotation imports [webview_flutter_wkwebview] Switch to quotation imports Mar 21, 2023
cyanglaz
cyanglaz reviewed Mar 21, 2023
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this will need a version update, right?

@bparrishMines
Copy link
Contributor Author

bparrishMines commented Mar 21, 2023

@cyanglaz That was super quick, thanks! I just added the version bump.

cyanglaz
cyanglaz approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bparrishMines bparrishMines added autosubmit Merge PR when tree becomes green via auto submit App and removed needs tests labels Mar 21, 2023
@auto-submit auto-submit bot merged commit 75491e9 into flutter:main Mar 22, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
75491e9 [webview_flutter_wkwebview] Switch to quotation imports (flut…
f0fd7fa 
…ter/packages#3511)
@bparrishMines bparrishMines deleted the ios_imports branch March 23, 2023 15:31
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@bparrishMines @nploi
[webview_flutter_wkwebview] Switch to quotation imports (flutter#3511)
59f0925 
[webview_flutter_wkwebview] Switch to quotation imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cyanglaz cyanglaz cyanglaz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: webview_flutter platform-ios

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bparrishMines @cyanglaz