Skip to content

[video_player] Add networkUri and deprecate network #3510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cscoderr wants to merge 1 commit into from
Closed

[video_player] Add networkUri and deprecate network #3510

cscoderr wants to merge 1 commit into from

Conversation

@cscoderr
Copy link

@cscoderr cscoderr commented Mar 21, 2023 •
edited
Loading

Add VideoPlayerController.networkUri and deprecate VideoPlayerController.network
See flutter/flutter#121927

Update README to effect the new changes
Update example folder remove deprecated VideoPlaterController.network

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cscoderr cscoderr requested a review from tarrinneal as a code owner March 21, 2023 20:37
@stuartmorgan-g stuartmorgan-g mentioned this pull request Mar 27, 2023
Merged
11 tasks
@stuartmorgan-g
Copy link
Collaborator

stuartmorgan-g commented Mar 27, 2023

This appears to be addressing the same issue as #3513; I would encourage the two of you to collaborate on a single PR.

@gmackall
Copy link
Member

gmackall commented Apr 13, 2023

It looks like some of the tests are failing, are you still looking into fixing these failures? Friendly reminder that this seems to be solving the same issue as #3513.

@stuartmorgan-g
Copy link
Collaborator

stuartmorgan-g commented Apr 14, 2023

Closing in favor of the other PR, as this version is not passing tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarrinneal tarrinneal Awaiting requested review from tarrinneal tarrinneal is a code owner

Assignees

No one assigned

Labels

p: video_player platform-ios

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cscoderr @stuartmorgan-g @gmackall