Skip to content

[shared_preferences] Add README discussion of reload #3508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Mar 21, 2023
Merged

[shared_preferences] Add README discussion of reload #3508

auto-submit merged 1 commit into from
Mar 21, 2023

Conversation

@stuartmorgan-g
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g commented Mar 21, 2023

Adds a section to the README about the caching behavior, and when it might be necessary to use reload() in an application to update the cache.

Fixes flutter/flutter#101691

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@stuartmorgan-g
[shared_preferences] Add README discussion of reload
92dda6a 
Adds a section to the README about the caching behavior, and when it
might be necessary to use `reload()` in an application to update the
cache.

Fixes flutter/flutter#101691
tarrinneal
tarrinneal approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@tarrinneal tarrinneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good write up

@tarrinneal tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 21, 2023
@auto-submit auto-submit bot merged commit 2f3fe12 into flutter:main Mar 21, 2023
@stuartmorgan-g stuartmorgan-g deleted the shared-prefs-reload-readme branch March 21, 2023 20:51
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
2f3fe12 [shared_preferences] Add README discussion of reload (flutter…
d335faa 
…/packages#3508)
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@stuartmorgan-g @nploi
[shared_preferences] Add README discussion of reload (flutter#3508)
16b6168 
[shared_preferences] Add README discussion of reload
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarrinneal tarrinneal tarrinneal approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: shared_preferences

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[shared_preferences] Document the need to use reload when using multiple isolates or engines

2 participants

@stuartmorgan-g @tarrinneal