Skip to content

[pigeon] removes experimental tag from swift and kotlin #3501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Mar 21, 2023
Merged

[pigeon] removes experimental tag from swift and kotlin #3501

auto-submit merged 3 commits into from
Mar 21, 2023

Conversation

@tarrinneal
Copy link
Contributor

@tarrinneal tarrinneal commented Mar 20, 2023

Since Kotlin and Swift have reached feature parity with other non-experimental generators it's time to remove the experimental tags from them.

We're so proud of you kotlin and swift generators, you've come so far!

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

stuartmorgan-g
stuartmorgan-g approved these changes Mar 21, 2023
View reviewed changes
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@tarrinneal tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 21, 2023
@auto-submit auto-submit bot merged commit 00b88f3 into flutter:main Mar 21, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
00b88f3 [pigeon] removes experimental tag from swift and kotlin (flut…
11a8dcf 
…ter/packages#3501)
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@tarrinneal @nploi
[pigeon] removes experimental tag from swift and kotlin (flutter#3501)
22aaeb6 
[pigeon] removes experimental tag from swift and kotlin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: pigeon platform-android platform-ios platform-macos platform-windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tarrinneal @stuartmorgan-g