Skip to content

Conversation

@stuartmorgan-g
Copy link
Collaborator

Converts the README from manually-maintained code snippets to using excerpts from a code file.

Also updates the snippet slightly:

  • Adds an example of a nullable method, to show that not all are non-nullable.
  • Removes the demonstrating of getting the string from the Directory, since that's not related to this package.

Includes sanity check tests of the snippet code to make sure it runs successfully.

Part of flutter/flutter#102679

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

Converts the README from manually-maintained code snippets to using
excerpts from a code file.

Also updates the snippet slightly:
- Adds an example of a nullable method, to show that not all are
  non-nullable.
- Removes the demonstrating of getting the string from the Directory,
  since that's not related to this package.

Includes sanity check tests of the snippet code to make sure it runs
successfully.

Part of flutter/flutter#102679
@stuartmorgan-g stuartmorgan-g added autosubmit Merge PR when tree becomes green via auto submit App emergency Override tree-status signal (land even with closed tree), combine with the autosubmit label. labels Mar 20, 2023
@stuartmorgan-g
Copy link
Collaborator Author

Overriding stale tree status

@auto-submit auto-submit bot merged commit 8955b6f into flutter:main Mar 21, 2023
@stuartmorgan-g stuartmorgan-g deleted the path-provider-excerpts branch March 21, 2023 11:58
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 21, 2023
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
[path_provider] Adopt readme excerpts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App emergency Override tree-status signal (land even with closed tree), combine with the autosubmit label. p: path_provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants