Skip to content

[go_router] Add navigator key to typed routes #3471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 7 commits into from
Mar 20, 2023
Merged

[go_router] Add navigator key to typed routes #3471

auto-submit merged 7 commits into from
Mar 20, 2023

Conversation

@GP4cK
Copy link
Contributor

@GP4cK GP4cK commented Mar 16, 2023

This PR is the first step described in #3439 (comment).

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@GP4cK GP4cK requested a review from chunhtai as a code owner March 16, 2023 02:10
@flutter-dashboard
Copy link

flutter-dashboard bot commented Mar 16, 2023

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@GP4cK GP4cK mentioned this pull request Mar 16, 2023
Merged
11 tasks
@GP4cK
Copy link
Contributor Author

GP4cK commented Mar 16, 2023

@chunhtai

  1. Should I create a new issue just to say that we need these navigator keys?
  2. For the tests, it seems trivial to add a test just to make sure we can create an instance of TypedShellRoute and TypedGoRoute by passing a navigator key. Shall I still do it?

chunhtai
chunhtai approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai
Copy link
Contributor

chunhtai commented Mar 20, 2023

This class is for annotation in go_router_builder, so I don't think it is testable in go_router package. The real test will be in go_router_builder when it starts to leverage the newly added parameters

@Hixie
Copy link
Contributor

Hixie commented Mar 20, 2023

test-exempt: code will be tested when applicable logic is added

@chunhtai chunhtai requested a review from johnpryan March 20, 2023 18:49
@johnpryan johnpryan added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 20, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 20, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 20, 2023

auto label is removed for flutter/packages, pr: 3471, due to - This commit is not mergeable and has conflicts. Please rebase your PR and fix all the conflicts.

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 20, 2023
@auto-submit auto-submit bot merged commit a901625 into flutter:main Mar 20, 2023
@GP4cK GP4cK deleted the add-navigator-key-to-typed-routes branch March 21, 2023 00:44
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 21, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 21, 2023
@engine-flutter-autoroll
a901625 [go_router] Add navigator key to typed routes (flutter/packag…
1a9255f 
…es#3471)
@GP4cK GP4cK mentioned this pull request Apr 1, 2023
Merged
11 tasks
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@GP4cK @nploi
[go_router] Add navigator key to typed routes (flutter#3471)
214c2fe 
[go_router] Add navigator key to typed routes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnpryan johnpryan johnpryan approved these changes

@chunhtai chunhtai chunhtai approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App needs tests p: go_router

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GP4cK @chunhtai @Hixie @johnpryan