Skip to content

[video_player_android] Enable -Werror and use dependency override #3412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 5 commits into from
Mar 11, 2023
Merged

[video_player_android] Enable -Werror and use dependency override #3412

auto-submit merged 5 commits into from
Mar 11, 2023

Conversation

@navaronbracke
Copy link
Contributor

@navaronbracke navaronbracke commented Mar 8, 2023

This PR enables warnings as errors for video_player_android.

List which issues are fixed by this PR. You must list at least one issue.
Part of flutter/flutter#91868

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
N/A

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@navaronbracke navaronbracke requested a review from camsim99 as a code owner March 8, 2023 11:18
@flutter-dashboard
Copy link

flutter-dashboard bot commented Mar 8, 2023

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

navaronbracke
navaronbracke commented Mar 8, 2023
View reviewed changes
@CaseyHillers
Copy link
Contributor

CaseyHillers commented Mar 8, 2023

test-exempt: Gradle lint was updated for an example app, which is verified in CI

@navaronbracke navaronbracke requested review from stuartmorgan-g and removed request for camsim99 March 8, 2023 15:58
@stuartmorgan-g stuartmorgan-g mentioned this pull request Mar 8, 2023
Closed
stuartmorgan-g
stuartmorgan-g approved these changes Mar 9, 2023
View reviewed changes
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 9, 2023
@navaronbracke
Copy link
Contributor Author

navaronbracke commented Mar 11, 2023

@stuartmorgan I bumped the version to 2.4.1 since apparently a newer version than my original change here was published before this one could land.

@auto-submit auto-submit bot merged commit a990169 into flutter:main Mar 11, 2023
@navaronbracke navaronbracke deleted the warnings_as_errors_video_player_android branch March 11, 2023 12:03
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 13, 2023
@engine-flutter-autoroll
a990169 [video_player_android] Enable -Werror and use dependency over…
1747aef 
…ride (flutter/packages#3412)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 13, 2023
@engine-flutter-autoroll
a990169 [video_player_android] Enable -Werror and use dependency over…
1bfeecb 
…ride (flutter/packages#3412)
@reidbaker reidbaker mentioned this pull request Mar 20, 2023
Merged
10 tasks
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@navaronbracke @nploi
[video_player_android] Enable -Werror and use dependency override (fl…
a900504 
…utter#3412)

[video_player_android] Enable -Werror and use dependency override
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@reidbaker reidbaker reidbaker approved these changes

@camsim99 camsim99 Awaiting requested review from camsim99

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App needs tests p: video_player platform-android

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@navaronbracke @CaseyHillers @stuartmorgan-g @reidbaker