Skip to content

[google_maps_flutter] Update example android configuration #3408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Mar 8, 2023
Merged

[google_maps_flutter] Update example android configuration #3408

auto-submit merged 1 commit into from
Mar 8, 2023

Conversation

@Rexios80
Copy link
Member

@Rexios80 Rexios80 commented Mar 7, 2023 •
edited by stuartmorgan-g
Loading

Updates the example android configuration to fix the following issue:

Fixes flutter/flutter#122137

I think this change should be exempt from a version bump since it only affects example configuration, but let me know if I should bump it anyways.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Rexios80 Rexios80 requested a review from stuartmorgan-g as a code owner March 7, 2023 22:24
@flutter-dashboard
Copy link

flutter-dashboard bot commented Mar 7, 2023

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Rexios80
Copy link
Member Author

Rexios80 commented Mar 7, 2023

Oh yeah I should probably explain that the only manual change here is bumping the gradle version to 7.4 in gradle-wrapper.properties so that the project could sync. The rest of the changes were done by the AGP Upgrade Assistant

This was referenced Mar 7, 2023
Merged
Merged
@CaseyHillers
Copy link
Contributor

CaseyHillers commented Mar 7, 2023

test-exempt: This is a version bump that is verified in CI

@stuartmorgan-g
Copy link
Collaborator

stuartmorgan-g commented Mar 8, 2023

The rest of the changes were done by the AGP Upgrade Assistant

@reidbaker Do you have an opinion on these automatic changes? I'm not aware of us ever having made these kind of other changes when updating AGP; if they are useful/necessary we should probably do them in general, but if not this is going to make these files different from the versions in all of the other examples.

@Rexios80
Copy link
Member Author

Rexios80 commented Mar 8, 2023

If you don't like the changes besides version bumps, I can revert them.

@reidbaker
Copy link
Contributor

reidbaker commented Mar 8, 2023

The rest of the changes were done by the AGP Upgrade Assistant

@reidbaker Do you have an opinion on these automatic changes? I'm not aware of us ever having made these kind of other changes when updating AGP; if they are useful/necessary we should probably do them in general, but if not this is going to make these files different from the versions in all of the other examples.

I am not opposed to these automatic changes. Until and Unless I feel like our decisions are better than the ones proposed by the tool I would like to defer to the tool.

@reidbaker reidbaker self-requested a review March 8, 2023 18:03
@reidbaker
Copy link
Contributor

reidbaker commented Mar 8, 2023

Please hold merging until/unless @stuartmorgan approves.

@stuartmorgan-g
Copy link
Collaborator

stuartmorgan-g commented Mar 8, 2023 •
edited
Loading

I am not opposed to these automatic changes. Until and Unless I feel like our decisions are better than the ones proposed by the tool I would like to defer to the tool.

Works for me. Ideally we should do this everywhere then; having the lint options be in different formats in different packages is not ideal.

Filed flutter/flutter#122213

@stuartmorgan-g stuartmorgan-g added the override: no changelog needed Override the check requiring CHANGELOG updates for most changes label Mar 8, 2023
@stuartmorgan-g
Copy link
Collaborator

stuartmorgan-g commented Mar 8, 2023

Exempt from changelog change: the manifest files that are triggering the failure are uninteresting to clients.

@stuartmorgan-g stuartmorgan-g mentioned this pull request Mar 8, 2023
Closed
@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 8, 2023
@auto-submit auto-submit bot merged commit 95a8a76 into flutter:main Mar 8, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 9, 2023
@engine-flutter-autoroll
95a8a76 Update android configuration (flutter/packages#3408)
14c1bde
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 9, 2023
@engine-flutter-autoroll
95a8a76 Update android configuration (flutter/packages#3408)
0163cff
@reidbaker reidbaker mentioned this pull request Mar 20, 2023
Merged
10 tasks
@reidbaker reidbaker mentioned this pull request Mar 28, 2023
Open
@reidbaker reidbaker mentioned this pull request Apr 19, 2023
Closed
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@Rexios80 @nploi
Update android configuration (flutter#3408)
71229c4 
[google_maps_flutter] Update example android configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@reidbaker reidbaker reidbaker approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App needs tests override: no changelog needed Override the check requiring CHANGELOG updates for most changes p: google_maps_flutter platform-android

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[google_maps_flutter] Update example app android configuration to fix building

4 participants

@Rexios80 @CaseyHillers @stuartmorgan-g @reidbaker