Skip to content

[image_picker] Update minimum Flutter version to 3.3 and iOS 11 #3327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Mar 1, 2023
Merged

[image_picker] Update minimum Flutter version to 3.3 and iOS 11 #3327

auto-submit merged 1 commit into from
Mar 1, 2023

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Feb 28, 2023 •
edited
Loading

image_picker part of flutter/flutter#101965.

Built the image_picker and image_picker_ios example projects on Flutter 3.3. and let the tool auto-migrate various Xcode project/Podfile files.

Remove pre-iOS 11 availability checks.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman requested a review from vashworth as a code owner February 28, 2023 21:02
@jmagman jmagman self-assigned this Feb 28, 2023
@jmagman jmagman requested a review from tarrinneal as a code owner February 28, 2023 21:02
vashworth
vashworth approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@vashworth vashworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 1, 2023
@auto-submit auto-submit bot merged commit ed1f780 into flutter:main Mar 1, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 1, 2023
@engine-flutter-autoroll
ed1f780 [image_picker] Update minimum Flutter version to 3.3 and iOS …
f9ce859 
…11 (flutter/packages#3327)
@jmagman jmagman deleted the ip-33 branch March 2, 2023 19:10
@reidbaker reidbaker mentioned this pull request Mar 20, 2023
Merged
10 tasks
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@jmagman @nploi
[image_picker] Update minimum Flutter version to 3.3 and iOS 11 (flut…
de67b65 
…ter#3327)

[image_picker] Update minimum Flutter version to 3.3 and iOS 11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vashworth vashworth vashworth approved these changes

@tarrinneal tarrinneal Awaiting requested review from tarrinneal tarrinneal is a code owner

Assignees

@jmagman jmagman

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: image_picker platform-ios

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmagman @vashworth