Skip to content

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Feb 25, 2023

camera part of flutter/flutter#101965.

Built the camera and camera_avfoundation example projects on Flutter 3.3. and let the tool auto-migrate various Xcode project/Podfile files.

Remove pre-iOS 11 availability checks.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman marked this pull request as ready for review February 27, 2023 18:25
Copy link
Contributor

@hellohuanlin hellohuanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious which tool did you use for the migration? (e.g. yaml, podspec, xcode settings)

@jmagman
Copy link
Member Author

jmagman commented Feb 27, 2023

curious which tool did you use for the migration?

It's flutter, the tool. It updates when flutter build ios/run flutter/flutter#101963

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 27, 2023
@auto-submit auto-submit bot merged commit 533be95 into flutter:main Feb 27, 2023
@jmagman jmagman deleted the camera-33 branch February 28, 2023 00:40
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 28, 2023
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
[camera] Update minimum Flutter version to 3.3 and iOS 11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: camera platform-ios

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants