[tool] Always run publish check #3279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Runs `pub publish --dry-run` on packages even when they have already been published, so that we will notice changes in `pub publish` behavior immediately. This will unfortunately make `publish-check` take significantly longer for changes that affect the entire repo, since it will run validation for every package instead of essentially skipping all of them, but currently repo-checks are one of our fastest tasks so the impact should be minimal. Fixes flutter/flutter#113788
stuartmorgan-g
requested review from
ditman,
domesticmouse and
gspencergoog
as code owners
stuartmorgan-g
added
override: no versioning needed
Collaborator
Author
|
No changelog/version bumps needed for removing files that will be auto-generated anyway. |
stuartmorgan-g
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/packages, pr: 3279, due to - The status or check suite android-platform_tests CHANNEL:master PACKAGE_SHARDING:--shardIndex 1 --shardCount 5 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 28, 2023
10 tasks
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
[tool] Always run publish check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs
pub publish --dry-runon packages even when they have already been published, so that we will notice changes inpub publishbehavior immediately.This will unfortunately make
publish-checktake significantly longer for changes that affect the entire repo, since it will run validation for every package instead of essentially skipping all of them, but currently repo-checks are one of our fastest tasks so the impact should be minimal.Also fixes violations found now that we are running it, where we had some git-ignored files checked in.
Fixes flutter/flutter#113788
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).