Skip to content

Conversation

@TimYusR
Copy link

@TimYusR TimYusR commented Feb 20, 2023

Update the google_sign_in dependency to 6.0.0 in the extension_google_sign_in_as_googleapis_auth package to update its dependency in google_sign_in_dartio package that fixes their compatibility.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@TimYusR TimYusR requested a review from ditman as a code owner February 20, 2023 12:05
@google-cla
Copy link

google-cla bot commented Feb 20, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@TimYusR TimYusR changed the title update google_sign_in dependency to 6.0.0 [extension_google_sign_in_as_googleapis_auth] update google_sign_in dependency to 6.0.0 Feb 20, 2023
@ditman
Copy link
Member

ditman commented Feb 22, 2023

@TimYusR thanks for the contribution!

I didn't see this one in my notifications and wrote my own here: #3235

Do you mind if we close this one and merge 3235?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants