Skip to content

Conversation

@stuartmorgan-g
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g commented Feb 10, 2023

Completes the migration of macOS CI tests to LUCI, since the Pigeon test issues in CI seems to be resolved now (likely due to the Xcode updates in CI).

Fixes flutter/flutter#120231

@stuartmorgan-g
Copy link
Collaborator Author

Closing for now since I'm not actively working on this.

@stuartmorgan-g stuartmorgan-g force-pushed the pigeon-finish-luci-migration branch from f9da669 to a9b4c93 Compare June 12, 2023 16:26
@stuartmorgan-g
Copy link
Collaborator Author

(Retesting to see if the problem has gone away with Xcode updates like some of our other macOS LUCI issues did.)

@stuartmorgan-g stuartmorgan-g marked this pull request as ready for review June 12, 2023 17:01
@stuartmorgan-g
Copy link
Collaborator Author

Hurray, it looks like it's working now!

Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 12, 2023
@auto-submit auto-submit bot merged commit 2d573fe into flutter:main Jun 12, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 13, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jun 13, 2023
flutter/packages@c9865e8...0507297

2023-06-12 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump com.google.guava:guava from 32.0.0-android to 32.0.1-android in /packages/camera/camera_android_camerax/android (flutter/packages#4195)
2023-06-12 [email protected] [ci] Finish migrating Pigeon tests to LUCI (flutter/packages#3192)
2023-06-12 49699333+dependabot[bot]@users.noreply.github.com [local_auth]: Bump androidx.fragment:fragment from 1.5.7 to 1.6.0 in /packages/local_auth/local_auth_android/android (flutter/packages#4186)
2023-06-12 49699333+dependabot[bot]@users.noreply.github.com [sign_in]: Bump com.google.guava:guava from 32.0.0-android to 32.0.1-android in /packages/google_sign_in/google_sign_in_android/android (flutter/packages#4184)
2023-06-12 [email protected] [go_router] Fixes a bug in `debugLogDiagnostics` to support StatefulShellRoute (flutter/packages#4177)
2023-06-12 [email protected] Roll Flutter from 3df163f to 353b8bc (10 revisions) (flutter/packages#4198)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: pigeon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pigeon integration tests hang on LUCI, but not Cirrus

2 participants