-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[ci] Finish migrating Pigeon tests to LUCI #3192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
auto-submit
merged 2 commits into
flutter:main
from
stuartmorgan-g:pigeon-finish-luci-migration
Jun 12, 2023
Merged
[ci] Finish migrating Pigeon tests to LUCI #3192
auto-submit
merged 2 commits into
flutter:main
from
stuartmorgan-g:pigeon-finish-luci-migration
Jun 12, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP for debugging flutter/flutter#120231
Collaborator
Author
|
Closing for now since I'm not actively working on this. |
f9da669 to
a9b4c93
Compare
Collaborator
Author
|
(Retesting to see if the problem has gone away with Xcode updates like some of our other macOS LUCI issues did.) |
Collaborator
Author
|
Hurray, it looks like it's working now! |
keyonghan
approved these changes
Jun 12, 2023
Contributor
keyonghan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 13, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 13, 2023
flutter/packages@c9865e8...0507297 2023-06-12 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump com.google.guava:guava from 32.0.0-android to 32.0.1-android in /packages/camera/camera_android_camerax/android (flutter/packages#4195) 2023-06-12 [email protected] [ci] Finish migrating Pigeon tests to LUCI (flutter/packages#3192) 2023-06-12 49699333+dependabot[bot]@users.noreply.github.com [local_auth]: Bump androidx.fragment:fragment from 1.5.7 to 1.6.0 in /packages/local_auth/local_auth_android/android (flutter/packages#4186) 2023-06-12 49699333+dependabot[bot]@users.noreply.github.com [sign_in]: Bump com.google.guava:guava from 32.0.0-android to 32.0.1-android in /packages/google_sign_in/google_sign_in_android/android (flutter/packages#4184) 2023-06-12 [email protected] [go_router] Fixes a bug in `debugLogDiagnostics` to support StatefulShellRoute (flutter/packages#4177) 2023-06-12 [email protected] Roll Flutter from 3df163f to 353b8bc (10 revisions) (flutter/packages#4198) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes the migration of macOS CI tests to LUCI, since the Pigeon test issues in CI seems to be resolved now (likely due to the Xcode updates in CI).
Fixes flutter/flutter#120231