[pigeon] Minor C++ output adjustments #3083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes a stray ; from an inline constructor. Fixes indentation for an inline vector construction.
tarrinneal
reviewed
Jan 23, 2023
tarrinneal
approved these changes
Jan 23, 2023
Collaborator
Author
|
The test failures were just me forgetting to update the version in the generator 🎉 |
stuartmorgan-g
added
the
autosubmit
sybrands-place
pushed a commit
to sybrands-place/packages
that referenced
this pull request
Jan 30, 2023
* main: (479 commits) removes raw ArrayLists (flutter#3101) Roll Flutter from c9affdb to 27f8ebd (15 revisions) (flutter#3098) [ci] Fix the new LUCI iOS build-all tasks (flutter#3099) [pigeon] [ObjC] Removes unused GetNullableObject function (flutter#3100) [pigeon] Swift host error handling (flutter#3084) Roll Flutter from a815ee6 to c9affdb (23 revisions) (flutter#3093) [ci] Enable min SDK version checks (flutter#3095) [pigeon] Fix C++ config handling (flutter#3094) [ci] Add LUCI version of iOS build-all (flutter#3096) [pigeon] Adds SwiftFunction annotation (flutter#2304) [flutter_adaptive_scaffold] Change `selectedIndex` on `standardNavigationRail` to allow null value. (flutter#3088) [pigeon] requires analyzer 5.2.0 (flutter#3090) Roll Flutter from c35efda to a815ee6 (22 revisions) (flutter#3089) [ci] Update legacy Flutter version tests (flutter#3087) Roll Flutter (stable) from 135454af3247 to b06b8b271095 (2551 revisions) (flutter#3086) [flutter_adaptive_scaffold] Fix leading and trailing Navigation Rail Widgets (flutter#3080) Roll Flutter from bd7bee0 to c35efda (24 revisions) (flutter#3085) [pigeon] Minor C++ output adjustments (flutter#3083) [pigeon] Updates writeScoped and addScoped to disallow symbol-less use. (flutter#3081) Roll Flutter from f33e8d3 to bd7bee0 (5 revisions) (flutter#3082) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
push_backinstead of initializer lists since it turns out the latter prevents move optimizations.flutter::from a number of common types in the implementation file. (This is something that would have been complicated before, but in the new two-class structure it's very easy to see which code needsflutter::and which doesn't by what class it's in.)Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).