Skip to content

[go_router_builder]Update the way to pass the extra param in router_config #3005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 13 commits into from
Feb 27, 2023
Merged

[go_router_builder]Update the way to pass the extra param in router_config #3005

auto-submit merged 13 commits into from
Feb 27, 2023

Conversation

@hannah-hyj
Copy link
Member

@hannah-hyj hannah-hyj commented Dec 27, 2022 •
edited
Loading

issue: flutter/flutter#111837

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@hannah-hyj hannah-hyj requested a review from chunhtai as a code owner December 27, 2022 20:48
@flutter-dashboard
Copy link

flutter-dashboard bot commented Dec 27, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@hannah-hyj hannah-hyj changed the title Remove extra param from go_router_builder [go_router_builder]Update router_config to not passing extra unconditionally Dec 27, 2022
@hannah-hyj
update extra
1d2a3ba 
This reverts commit 36213a45c8f7cedb4e6b4d7d650eac2b1802d341.

remove extra

update log

update tests

update

Update CHANGELOG.md

lint

lint
@hannah-hyj hannah-hyj changed the title [go_router_builder]Update router_config to not passing extra unconditionally [go_router_builder]Update the way to pass the extra param in router_config Dec 27, 2022
chunhtai
chunhtai reviewed Jan 4, 2023
View reviewed changes
@stuartmorgan-g
Copy link
Collaborator

stuartmorgan-g commented Jan 31, 2023

@Hangyujin What's the status of this PR? Are you planning on updating it based on the discussion above?

@chunhtai
Copy link
Contributor

chunhtai commented Feb 2, 2023

(triage) @Hangyujin said she will come back to this pr soon.

@hannah-hyj
Merge branch 'main' of https://github.com/flutter/packages into remov…
0acae1b 
…e-extra-2
@hannah-hyj
test
f285527 
Revert "test"

This reverts commit d748242967a0a3805364d438bc81f39cf3804cc7.

Update main.dart
@hannah-hyj hannah-hyj requested a review from chunhtai February 8, 2023 01:17
chunhtai
chunhtai previously approved these changes Feb 16, 2023
View reviewed changes
@chunhtai chunhtai dismissed their stale review February 16, 2023 19:58

accidentally approved

@hannah-hyj hannah-hyj requested a review from chunhtai February 26, 2023 03:19
chunhtai
chunhtai approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hannah-hyj hannah-hyj added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 27, 2023
@auto-submit auto-submit bot merged commit a2c5062 into flutter:main Feb 27, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 28, 2023
@engine-flutter-autoroll
a2c5062 [go_router_builder]Update the way to pass the extra param i…
31e46a5 
…n router_config (flutter/packages#3005)
@reidbaker reidbaker mentioned this pull request Mar 20, 2023
Merged
10 tasks
@Skogsfrae Skogsfrae mentioned this pull request May 3, 2023
Open
2 tasks
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@hannah-hyj @nploi
[go_router_builder]Update the way to pass the extra param in router…
ad062f8 
…_config (flutter#3005)

[go_router_builder]Update the way to pass the `extra` param in router_config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chunhtai chunhtai chunhtai approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App needs tests p: go_router_builder

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hannah-hyj @stuartmorgan-g @chunhtai