Skip to content

[pigeon] Remove legacy iOS unit test harness #2868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stuartmorgan-g wants to merge 1 commit into from
Closed

[pigeon] Remove legacy iOS unit test harness #2868

stuartmorgan-g wants to merge 1 commit into from

Conversation

@stuartmorgan-g
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g commented Dec 1, 2022

Removes the legacy iOS unit test harness,
platform_tests/ios_unit_test, and enables the new harness by default in run_tests.sh (and thus in CI).

Also enables the iOS integration tests in the new harness by default.

See #2816 for background.

Part of flutter/flutter#111505

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@stuartmorgan-g
[pigeon] Remove legacy iOS unit test harness
e83da98 
Removes the legacy iOS unit test harness,
`platform_tests/ios_unit_test`, and enables the new harness by default
in run_tests.sh (and thus in CI).

Also enables the iOS integration tests in the new harness by default.
@stuartmorgan-g stuartmorgan-g added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Dec 1, 2022
@stuartmorgan-g stuartmorgan-g marked this pull request as draft December 1, 2022 01:15
@stuartmorgan-g
Copy link
Collaborator Author

stuartmorgan-g commented Dec 1, 2022

This is the successor to #2816; it will have the same blocking CI issues.

This was referenced Dec 1, 2022
Closed
Closed
@stuartmorgan-g
Copy link
Collaborator Author

stuartmorgan-g commented Jan 4, 2023

I tried this as an Intel LUCI task in #2869 and it also hung there, so it seems like this isn't just the ARM thing. I'll have to keep digging into why this hangs in CI but not locally.

@stuartmorgan-g
Copy link
Collaborator Author

stuartmorgan-g commented Feb 9, 2023

Obsoleted by the recent partial LUCI migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarrinneal tarrinneal Awaiting requested review from tarrinneal tarrinneal is a code owner

@gaaclarke gaaclarke Awaiting requested review from gaaclarke

Assignees

No one assigned

Labels

override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: pigeon

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@stuartmorgan-g