[ci] Add LUCI version of macOS custom tests #2855
Conversation
This adds a bringup LUCI version of the macOS-host custom package tests. This is the first attempt to migrate a flutter/packages or flutter/plugins test to macOS ARM, so is experimental. The motivation for doing this migration now is to see if it can unblock flutter#2816, which doesn't seem to be able to run successfully on Cirrus ARM machines (very possibly due to the same issue that blocked flutter/plugins migrations to ARM on Cirrus).
|
(If this doesn't end up working, I'll try a LUCI Intel version of this test instead to see if that unblocks the iOS pigeon PR.) |
| channel: stable | ||
|
|
||
| - name: Mac_arm64 custom_package_tests master | ||
| bringup: true # New configuration |
There was a problem hiding this comment.
Did you try a led run with this? Suspect you'll hit flutter/flutter#113231
There was a problem hiding this comment.
My led-fu is very weak, but I though the task config already had to exist to point to in a led run. Is that no longer the case?
There was a problem hiding this comment.
Technically you can copy an existing config and edit it go/flutter-luci-recipes#testing-a-local-change-for-a-new-builderrecipe. However I've never had the patience to do that.
Usually I remove bringup and presubmit in the PR and let it run in presubmit, and then revert that before merging. ci.yaml validation would fail though. You can normally be sneaky and use an existing test and just say swap out target_file to have it run in presubmit, but you have the added complication of there being no existing Mac_arm64 builders.
There was a problem hiding this comment.
Yeah, that sounds about like what I've done in the past; this was to bootstrap me to something where I could play around with things in presubmit in a follow-up PR.
But since we have known ARM breakage I'll hold off on this, and maybe explore doing an Intel version instead. Thanks for the pointer to that issue!
jmagman
left a comment
jmagman
left a comment
There was a problem hiding this comment.
Change LGTM though I suspect this may fail due to arm infra issues. Worth a shot though.
|
Re-opening to try again now that flutter/flutter#113231 is fixed. |
stuartmorgan-g
added
the
autosubmit
3 participants
This adds a bringup LUCI version of the macOS-host custom package tests. This is the first attempt to migrate a flutter/packages or flutter/plugins test to macOS ARM, so is experimental.
The motivation for doing this migration now is to see if it can unblock #2816, which doesn't seem to be able to run successfully on Cirrus ARM machines (very possibly due to the same issue that blocked flutter/plugins migrations to ARM on Cirrus).