[pigeon] Consolidate platform test harnesses part 3.2 - iOS ObjC #2816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
requested review from
gaaclarke and
tarrinneal
as code owners
stuartmorgan-g
changed the title
stuartmorgan-g
added
override: no versioning needed
11 tasks
Collaborator
Author
|
See comments in #2811 for debugging notes abut the hang here; it's still not clear what the cause is. |
tarrinneal
approved these changes
Nov 16, 2022
Contributor
tarrinneal
left a comment
tarrinneal
left a comment
There was a problem hiding this comment.
are these new? I feel like I've approved these changes already
Collaborator
Author
|
When the combined iOS PR was hanging, I split it again into ObjC and Swift to further isolate it. (It turns out it's the ObjC part.) |
11 tasks
stuartmorgan-g
added a commit
to stuartmorgan-g/packages
that referenced
this pull request
Nov 28, 2022
This sets up initial proof-of-concept integration tests using the new shared native test harness: - Integration tests on the Dart side for void->void and Everything->Everything calls. - macOS implementations in the test plugin on the native side. - A new test target in the test script to drive them via `flutter test`. - A minimal change to the example app so that `flutter run`-ing it will test that the void->void call is wired up. Since this simple initial test hit flutter/flutter#111083, which caused the test to fail, this includes a fix for that. Short-term future work (by me): - Add integration test native setup and script targets for the other generators. This includes one just to keep the initial review scope smaller. - Update flutter#2816 to include the integration test since it's still blocked until I can address the CI issues. Medium-term future work (not all by me): - Remove the legacy iOS e2e test scaffold that is currently disabled. - Add significantly more integration test coverage (likely including flutter/flutter#115168 to reduce redundant API setup), including Flutter API integration tests rather than just host API tests. Part of flutter/flutter#111505 Fixes flutter/flutter#111083
11 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Nov 28, 2022
* [pigeon] Initial integration test setup This sets up initial proof-of-concept integration tests using the new shared native test harness: - Integration tests on the Dart side for void->void and Everything->Everything calls. - macOS implementations in the test plugin on the native side. - A new test target in the test script to drive them via `flutter test`. - A minimal change to the example app so that `flutter run`-ing it will test that the void->void call is wired up. Since this simple initial test hit flutter/flutter#111083, which caused the test to fail, this includes a fix for that. Short-term future work (by me): - Add integration test native setup and script targets for the other generators. This includes one just to keep the initial review scope smaller. - Update #2816 to include the integration test since it's still blocked until I can address the CI issues. Medium-term future work (not all by me): - Remove the legacy iOS e2e test scaffold that is currently disabled. - Add significantly more integration test coverage (likely including flutter/flutter#115168 to reduce redundant API setup), including Flutter API integration tests rather than just host API tests. Part of flutter/flutter#111505 Fixes flutter/flutter#111083 * Version bump for bugfix * Check in generated files needed for analysis * Add the actual integration test file, which was left out * Address review comments * Fix incorrect Swift unit test for void call fix * Analysis ignore * Autoformat
8 tasks
stuartmorgan-g
added a commit
to stuartmorgan-g/packages
that referenced
this pull request
Nov 29, 2022
This adds a bringup LUCI version of the macOS-host custom package tests. This is the first attempt to migrate a flutter/packages or flutter/plugins test to macOS ARM, so is experimental. The motivation for doing this migration now is to see if it can unblock flutter#2816, which doesn't seem to be able to run successfully on Cirrus ARM machines (very possibly due to the same issue that blocked flutter/plugins migrations to ARM on Cirrus).
This was referenced Nov 30, 2022
Collaborator
Author
|
The addition part of this landed in #2867, and it was actually easier to just make a new branch to re-do the removal part than to merge into this one. So closing in favor of: |
auto-submit bot
pushed a commit
that referenced
this pull request
Jan 14, 2023
This adds a bringup LUCI version of the macOS-host custom package tests. This is the first attempt to migrate a flutter/packages or flutter/plugins test to macOS ARM, so is experimental. The motivation for doing this migration now is to see if it can unblock #2816, which doesn't seem to be able to run successfully on Cirrus ARM machines (very possibly due to the same issue that blocked flutter/plugins migrations to ARM on Cirrus).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2803; see also #2811
As a minor opportunistic change since imports needed to be changed anyway, this updates the ObjC test imports to use modules.
Part of flutter/flutter#111505
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).