-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[go_router] Add documentation using dartdoc topics #2789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
nested.md is an empty file, is it still WIP? |
|
You're right, it looks like I forgot the nested navigation docs. I'll add those back. |
sfshaza2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
chunhtai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, % nits
loic-sharma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome. Excellent docs 🥇
|
auto label is removed for flutter/packages, pr: 2789, due to - Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead. |
|
auto label is removed for flutter/packages, pr: 2789, due to - This pull request has changes requested by @chunhtai. Please resolve those before re-applying the label. |
|
auto label is removed for flutter/packages, pr: 2789, due to - Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead. |
|
auto label is removed for flutter/packages, pr: 2789, due to - This pull request has changes requested by @chunhtai. Please resolve those before re-applying the label. |
|
@chunhtai could you take another look? |
| visible at the bottom of the | ||
| screen. | ||
| - Support for both Material and Cupertino apps | ||
| - Backwards-compatibility with Navigator API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heads up: this list has inconsistent use of periods at the end of items.
chunhtai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
auto label is removed for flutter/packages, pr: 2789, due to - The status or check suite dart_unit_tests CHANNEL:master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
auto label is removed for flutter/packages, pr: 2789, due to - The status or check suite dart_unit_tests CHANNEL:master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
This adds documentation using Dartdoc's "topics" feature. Each section is displayed as part of the dartdoc documentation:
fixes flutter/flutter#115078
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).