[Pigeon] Condenses serialization formats#2745
Merged
Merged
Conversation
gaaclarke
reviewed
Oct 28, 2022
gaaclarke
left a comment
gaaclarke
left a comment
Member
There was a problem hiding this comment.
I gave this a quick look and it's all in the right place. One thing to make sure is that there is an explicit defined order of the fields when they are written. Writing them in the order they show up in the pigeon file is good. I'd just make sure that's the case.
gaaclarke
reviewed
Nov 2, 2022
tarrinneal
marked this pull request as ready for review
November 23, 2022 23:19
- Fix API call typo. - Fix double nesting of arrays for class serialization. - Replace incorrect emplace calls with push_back. - Start to update unit tests.
stuartmorgan-g
approved these changes
Dec 13, 2022
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
Collaborator
There was a problem hiding this comment.
All languages complete! Other than the Kotlin wrapError thing it's all very minor.
I'm going to LGTM with these comments since I don't think anything here should need re-review, but if there's anything you change that you want me to look at let me know.
gaaclarke
reviewed
Dec 14, 2022
gaaclarke
left a comment
gaaclarke
left a comment
Member
There was a problem hiding this comment.
Wowee, there is a lot more to review now. 2 big things, the rest you can ignore:
- I think you have a bug in the c++ generator
- I think we should avoid building wrapped values by using
.addmethods, instead indexing exactly where the values should go.
gaaclarke
approved these changes
Dec 15, 2022
gaaclarke
left a comment
gaaclarke
left a comment
Member
There was a problem hiding this comment.
LGTM! Thanks for tackling this, a brave new world for pigeon.
tarrinneal
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/packages, pr: 2745, due to - The status or check suite ios-build_all_packages CHANNEL:master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
tarrinneal
added
the
autosubmit
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
* Fixs missed indents on generated comments * begin improved serialization * formatting errors * Dart encoder updated to use lists, tests to match * Begin swift serial, change error shape * update tests for swift and dart * true > false * Return to Object * correctly nest lists in dart and tests * Kotlin gen and tests updated to lists * Java and Tests updated to new serials * Stuart check this pr (start of objc changes) * obj c tests for serial * update unit tests to match new generated outputs * finish objc tests * More kt tests * c++ generator and unit tests * analyze, format, changelog * test file updates for ci * format and analyze again * a few more test generated files * Partial Windows fixes - Fix API call typo. - Fix double nesting of arrays for class serialization. - Replace incorrect emplace calls with push_back. - Start to update unit tests. * null field tests c++ * format * fix merge issue with broken test * remove unneeded wrapping * generated files * fix some formatting errors * format * more gen files * gen files * generator reviews pt1 * test fixes pt1 * fixed nits and nil issues with objc * better fix for objc null classes * fix doc comment * unit test updates * format * some c++ fixes * typo * format * Some nits and such * comment * remove deleted files * c++ nits * objc nits * all but one c++ bug * init all fields * start of documenting data shape * nits and error handling * more nits and such * bug? * references * const * new null for larger alltypes Co-authored-by: Stuart Morgan <[email protected]>
bisor0627
pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
* Fixs missed indents on generated comments * begin improved serialization * formatting errors * Dart encoder updated to use lists, tests to match * Begin swift serial, change error shape * update tests for swift and dart * true > false * Return to Object * correctly nest lists in dart and tests * Kotlin gen and tests updated to lists * Java and Tests updated to new serials * Stuart check this pr (start of objc changes) * obj c tests for serial * update unit tests to match new generated outputs * finish objc tests * More kt tests * c++ generator and unit tests * analyze, format, changelog * test file updates for ci * format and analyze again * a few more test generated files * Partial Windows fixes - Fix API call typo. - Fix double nesting of arrays for class serialization. - Replace incorrect emplace calls with push_back. - Start to update unit tests. * null field tests c++ * format * fix merge issue with broken test * remove unneeded wrapping * generated files * fix some formatting errors * format * more gen files * gen files * generator reviews pt1 * test fixes pt1 * fixed nits and nil issues with objc * better fix for objc null classes * fix doc comment * unit test updates * format * some c++ fixes * typo * format * Some nits and such * comment * remove deleted files * c++ nits * objc nits * all but one c++ bug * init all fields * start of documenting data shape * nits and error handling * more nits and such * bug? * references * const * new null for larger alltypes Co-authored-by: Stuart Morgan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Condenses the serialization platform of generated api's by converting objects to lists
List which issues are fixed by this PR. You must list at least one issue.
fixes flutter/flutter#111503
fixes flutter/flutter#111722
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
tbc
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.