Actually call argument-less methods. #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 20, 2021
Closed
Hixie
force-pushed
the
arg-less
branch
3 times, most recently
from
f237f0f to
8fac8fd
Compare
blasten
reviewed
Jan 21, 2021
Contributor
There was a problem hiding this comment.
Is message always null when argType is void?
Contributor
Author
There was a problem hiding this comment.
Do you mean in pigeon-generated code? Or?
Contributor
There was a problem hiding this comment.
yup. pigeon-generated code
Contributor
Author
There was a problem hiding this comment.
it looks like _writeHostApi always sends null if the argType is void, but of course people can always bypass pigeon and send whatever.
blasten
reviewed
Jan 21, 2021
Contributor
There was a problem hiding this comment.
does it make sense to also verify the message?
blasten
reviewed
Jan 21, 2021
Contributor
There was a problem hiding this comment.
minor nit: some comment would be helpful. It took me a while to figure out what it was checking :)
8 tasks
Contributor
Author
|
Blocked on flutter/flutter#74446 which fixes the test failure in |
Hixie
force-pushed
the
arg-less
branch
2 times, most recently
from
a95a041 to
2671601
Compare
Hixie
force-pushed
the
arg-less
branch
6 times, most recently
from
8d1a0f6 to
9db165e
Compare
I accidentally broke this in an earlier patch.
Contributor
Author
|
Horrah the tests pass now. |
Contributor
Author
|
Landing! |
stuartmorgan-g
pushed a commit
to stuartmorgan-g/packages
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally broke this in an earlier patch.