Skip to content

Conversation

@mit-mit
Copy link
Member

@mit-mit mit-mit commented Aug 30, 2022

Migrate the rest of imitation_game and pigeon to full null safety.

Contributes to flutter/flutter#110024

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@mit-mit mit-mit changed the title Migrate more to null safety Migrate imitation_game and pigeon to null safety Aug 30, 2022
@mit-mit mit-mit requested a review from stuartmorgan-g August 30, 2022 12:49
@mit-mit
Copy link
Member Author

mit-mit commented Aug 30, 2022

Hi @stuartmorgan I took a stab at migrating some more stuff to null safety.

I'm not sure what is causing the Android test failure; I didn't change any of that?

As for the publishing error, should I rev the versions given this is only some test stuff?

@stuartmorgan-g
Copy link
Collaborator

There's not much information in that failure log; I'm re-running it to see if it's flake.

No need for version changes here, the heuristics just don't know about these non-standard test structures.

@stuartmorgan-g stuartmorgan-g added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Aug 30, 2022
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mit-mit mit-mit merged commit 2628e35 into flutter:main Aug 30, 2022
@mit-mit mit-mit deleted the nullsafety2 branch August 30, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs tests override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: imitation_game p: pigeon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants