[dynamic_layouts] Add base classes for building dynamic grids #2488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks like some checks are unhappy. You're probably missing a run of the dart formatter? |
goderbauer
reviewed
Aug 23, 2022
Contributor
Author
You read my mind. :) |
goderbauer
reviewed
Aug 23, 2022
Member
goderbauer
left a comment
goderbauer
left a comment
There was a problem hiding this comment.
not a full review, just some quick nits found between meetings.
goderbauer
approved these changes
Aug 24, 2022
| @@ -0,0 +1,30 @@ | |||
| # Miscellaneous | |||
Member
There was a problem hiding this comment.
Can we just use the global .gitignore [1] or do we need a special one?
Contributor
Author
There was a problem hiding this comment.
Oh I was looking at adaptive_scaffold for comparison, it has the same .gitignore, should they be removed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the base upon which @DavBot02 and @snat-s will be adding their dynamic grid layouts.
This package will remain unpublished while their changes are added.
See their design documents here:
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.