Skip to content

fix: [go_router] Extra parameter is always null in route level redirect callback #2404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
johnpryan merged 10 commits into from
Aug 2, 2022
Merged

fix: [go_router] Extra parameter is always null in route level redirect callback #2404

johnpryan merged 10 commits into from
Aug 2, 2022

Conversation

@Semapl3
Copy link
Contributor

@Semapl3 Semapl3 commented Aug 2, 2022

repeat (#2308)

Semapl3 added 10 commits July 5, 2022 22:31
@Semapl3
fix: [go_router] Extra parameter is always null in route level redire…
6066d43 
…ct callback #106164

flutter/flutter#106164
@Semapl3
fix: version
22e6193
@Semapl3
fix: changelog
b63deed
@Semapl3
fix: that was a typo
51b21bb
@Semapl3
fix: That was a typo
adb1c84
@Semapl3
feat: add test flutter/flutter#106164
dbbc5a5
@Semapl3
Merge remote-tracking branch 'origin_of/main'
4ff6ebe 
# Conflicts:
#	packages/go_router/CHANGELOG.md
#	packages/go_router/lib/src/go_route_information_parser.dart
#	packages/go_router/pubspec.yaml
@Semapl3
fix: after merge
75aa2d9
@Semapl3
feat: add test, check call redirect
5fb70ae
@Semapl3
Merge branch 'main' into fix
7787303 
# Conflicts:
#	packages/go_router/CHANGELOG.md
#	packages/go_router/pubspec.yaml
@Semapl3 Semapl3 mentioned this pull request Aug 2, 2022
Closed
@Semapl3 Semapl3 marked this pull request as ready for review August 2, 2022 08:37
chunhtai
chunhtai approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai requested a review from johnpryan August 2, 2022 15:35
@johnpryan johnpryan merged commit bf82745 into flutter:main Aug 2, 2022
@sarbagyastha sarbagyastha mentioned this pull request Aug 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnpryan johnpryan johnpryan approved these changes

@chunhtai chunhtai chunhtai approved these changes

Assignees

No one assigned

Labels

p: go_router

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Semapl3 @johnpryan @chunhtai